Skip to content

Commit 2508869

Browse files
return <></>
1 parent 4fba9f5 commit 2508869

File tree

1 file changed

+26
-24
lines changed

1 file changed

+26
-24
lines changed

packages/compass-schema/src/components/compass-schema.tsx

Lines changed: 26 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -351,31 +351,33 @@ const PerformanceAdvisorBanner = () => {
351351
false
352352
);
353353

354+
if (dismissed) {
355+
return <></>;
356+
}
357+
354358
return (
355-
!dismissed && (
356-
<Banner variant="info" dismissible onClose={() => setDismissed(true)}>
357-
<Body weight="medium">Looking for schema anti-patterns?</Body>
358-
In its place, you may refer to Data Explorer’s performance insights{' '}
359-
<Badge className={insightsBadgeStyles} variant="blue">
360-
<Icon glyph="Bulb" size="small" />
361-
Insight
362-
</Badge>
363-
{nbsp}or{nbsp}
364-
{connectionInfo.atlasMetadata ? (
365-
<Link
366-
href={getAtlasPerformanceAdvisorLink(connectionInfo.atlasMetadata)}
367-
onClick={() =>
368-
track('Performance Advisor Clicked', {}, connectionInfo)
369-
}
370-
hideExternalIcon
371-
>
372-
{title}
373-
</Link>
374-
) : (
375-
title
376-
)}
377-
</Banner>
378-
)
359+
<Banner variant="info" dismissible onClose={() => setDismissed(true)}>
360+
<Body weight="medium">Looking for schema anti-patterns?</Body>
361+
In its place, you may refer to Data Explorer’s performance insights{' '}
362+
<Badge className={insightsBadgeStyles} variant="blue">
363+
<Icon glyph="Bulb" size="small" />
364+
Insight
365+
</Badge>
366+
{nbsp}or{nbsp}
367+
{connectionInfo.atlasMetadata ? (
368+
<Link
369+
href={getAtlasPerformanceAdvisorLink(connectionInfo.atlasMetadata)}
370+
onClick={() =>
371+
track('Performance Advisor Clicked', {}, connectionInfo)
372+
}
373+
hideExternalIcon
374+
>
375+
{title}
376+
</Link>
377+
) : (
378+
title
379+
)}
380+
</Banner>
379381
);
380382
};
381383

0 commit comments

Comments
 (0)