cr feedback

Author: mabaasit

.evergreen/start-atlas-cloud-cluster.sh

@@ -16,6 +16,9 @@
 #
 # - Setup a new org and project. Save the org id and project id for later.
 #
+# - Add payment details within the organization (Billing) to be able to create
+#   clusters. You can use test stripe card for that (4242 4242 4242 4242).
+#
 # - Create new db user with username / password auth and admin role. This user
 #   will be used to prepopulate dbs with data in tests. Save the credentials.
 #
@@ -47,10 +50,6 @@
 #   (ATLAS_CLOUD_TEST_CLUSTER_NAME="TestCluster" source .evergreen/start-atlas-cloud-cluster.sh \
 #     && npm run -w compass-e2e-tests test web -- --test-atlas-cloud-sandbox --test-filter="atlas-cloud/**/*")
 #
-# When setting up for the first time, make sure you:
-# - Add payment details to be able to create clusters. You can use stripe test card.
-# - Allow network access to the project for your IP address.
-
 _ATLAS_CLOUD_TEST_CLUSTER_NAME=${ATLAS_CLOUD_TEST_CLUSTER_NAME:-""}
 
 # Atlas limits the naming to something like /^[\w\d-]{,23}$/ (and will auto

packages/compass-e2e-tests/helpers/selectors.ts

@@ -1402,8 +1402,7 @@ export const ProxyCustomButton =
 export const ConfirmTabCloseModal = '[data-testid="confirm-tab-close"]';
 
 export const GlobalWrites = {
-  tabStatus: (status: string) =>
-    `[data-testid="${status.toLowerCase()}-status"]`,
+  tabStatus: (status: string) => `[data-status="${status.toLowerCase()}"]`,
 
   ShardKeyFormSecondKeyInputCombobox:
     '[data-testid="second-shard-key"] [role="combobox"] input',

packages/compass-e2e-tests/tests/atlas-cloud/global-writes.test.ts

@@ -69,9 +69,6 @@ describe('Global writes', function () {
   });
 
   it('should be able to shard an unsharded namespace and also unmanage it', async function () {
-    // Sharding a collection takes a bit longer
-    this.timeout(60_000);
-
     await createGeospatialCollection();
     await browser.connectToDefaults();
     await browser.navigateToCollectionTab(

packages/compass-global-writes/src/components/index.tsx

@@ -98,10 +98,7 @@ function ShardingStateView({
 
 export function GlobalWrites({ shardingStatus }: GlobalWritesProps) {
   return (
-    <div
-      className={containerStyles}
-      data-testid={`${shardingStatus.toLowerCase()}-status`}
-    >
+    <div className={containerStyles} data-status={shardingStatus.toLowerCase()}>
       <WorkspaceContainer className={workspaceContentStyles}>
         <ConfirmationModalArea>
           <ShardingStateView shardingStatus={shardingStatus} />