Skip to content

Commit 28c1110

Browse files
committed
💚 👕
1 parent e5fa7de commit 28c1110

File tree

9 files changed

+32
-30
lines changed

9 files changed

+32
-30
lines changed

gulpfile.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,9 @@ gulp.task('watch', function() {
126126
/**
127127
* Use browserify to compile the UI js.
128128
*/
129+
var jadeify = require('jadeify');
129130
gulp.task('build:js', function() {
130-
var bundler = browserify(pkg.browserify).transform('jadeify');
131+
var bundler = browserify(pkg.browserify).transform(jadeify);
131132
if (process.env.NODE_ENV === 'production') {
132133
return bundler.bundle()
133134
.on('error', notify('js'))

package.json

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,21 @@
2222
"./tasks/linux.js"
2323
],
2424
"ignore": [
25-
"app",
26-
"auto-updater",
27-
"bootstrap",
28-
"browser-window",
25+
"app",
26+
"auto-updater",
27+
"bootstrap",
28+
"browser-window",
2929
"clipboard",
30-
"crash-reporter",
31-
"dialog",
32-
"electron-squirrel-startup",
33-
"font-awesome",
34-
"glob",
35-
"ipc",
36-
"jade",
37-
"keytar",
38-
"menu",
39-
"octicons",
30+
"crash-reporter",
31+
"dialog",
32+
"electron-squirrel-startup",
33+
"font-awesome",
34+
"glob",
35+
"ipc",
36+
"jade",
37+
"keytar",
38+
"menu",
39+
"octicons",
4040
"scout-server"
4141
]
4242
},
@@ -116,7 +116,6 @@
116116
"electron-installer-dmg": "^0.1.0",
117117
"electron-installer-squirrel-windows": "^0.4.0",
118118
"electron-packager": "^5.1.1",
119-
<<<<<<< 50eddee91c762cac77586943130d76ca301908cb
120119
"eslint": "^1.9.0",
121120
"eslint-config-mongodb-js": "^1.0.6",
122121
"event-stream": "^3.3.2",

src/app.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -237,9 +237,9 @@ var Application = View.extend({
237237
});
238238

239239
var params = qs.parse(window.location.search.replace('?', ''));
240-
var connection_id = params.connection_id;
240+
var connectionId = params.connection_id;
241241
var state = new Application({
242-
connection_id: connection_id
242+
connection_id: connectionId
243243
});
244244

245245
/**
@@ -296,7 +296,7 @@ app.extend({
296296
domReady(function() {
297297
state.render();
298298

299-
if (!connection_id) {
299+
if (!connectionId) {
300300
// Not serving a part of the app which uses the client,
301301
// so we can just start everything up now.
302302
state.startRouter();
@@ -306,10 +306,10 @@ app.extend({
306306
app.statusbar.show('Retrieving connection details...');
307307

308308
state.connection = new Connection({
309-
_id: connection_id
309+
_id: connectionId
310310
});
311311

312-
debug('looking up connection `%s`...', connection_id);
312+
debug('looking up connection `%s`...', connectionId);
313313
getConnection(state.connection, function(err) {
314314
if (err) {
315315
state.onFatalError('fetch connection', err);

src/models/scout-client-mixin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ module.exports = {
3030
if (err) {
3131
return options.error({}, 'error', err.message);
3232
}
33-
raf(function call_scout_client_success() {
33+
raf(function onScoutClientSuccess() {
3434
options.success(res, 'success', res);
3535
});
3636
};

src/models/selectable-collection-mixin.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ module.exports = {
6161
if (model.selected) {
6262
return false;
6363
}
64-
raf(function selectable_mark_selected() {
64+
raf(function selectableMarkModelSelected() {
6565
var current = this.selected;
6666
if (current) {
6767
current.selected = false;

src/models/user.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ var User = Model.extend({
1212
created_at: 'date',
1313
avatar_url: 'string',
1414
company_name: 'string'
15-
// github_username: 'string',
16-
/**
17-
* `public_repos + public_gists + followers + following`
18-
*/
19-
// github_score: 'number',
20-
// github_last_activity_at: 'date'
15+
// github_username: 'string',
16+
/**
17+
* `public_repos + public_gists + followers + following`
18+
*/
19+
// github_score: 'number',
20+
// github_last_activity_at: 'date'
2121
},
2222
sync: sync.exec.bind(sync)
2323
});

tasks/linux.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint no-console:0 */
12
var path = require('path');
23
var pkg = require(path.resolve(__dirname, '../package.json'));
34
var fs = require('fs');

tasks/notify.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/* eslint no-console:0 */
12
var notifier = require('node-notifier');
23
var path = require('path');
34
var gutil = require('gulp-util');

test/keytar.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ describe('keytar', function() {
44
it('should be requirable', function() {
55
assert.doesNotThrow(function() {
66
require('keytar');
7-
})
7+
});
88
});
99
});

0 commit comments

Comments
 (0)