chore(components): revert changes to webpack config; patch button to add the missing export

Author: gribnoysup

configs/webpack-config-compass/polyfills/@leafygreen-ui/button/constants/index.js

@@ -102,17 +102,6 @@ const sharedResolveOptions = (
         'index.js'
       ),
 
-      // TODO: document what's going on here
-      '@leafygreen-ui/button/constants': path.resolve(
-        __dirname,
-        '..',
-        'polyfills',
-        '@leafygreen-ui',
-        'button',
-        'constants',
-        'index.js'
-      ),
-
       // This is an optional dependency of the AWS SDK that doesn't look like
       // an optional dependency to webpack because it's not wrapped in try/catch.
       '@aws-sdk/client-sso-oidc': false,
@@ -287,10 +276,10 @@ export function createElectronRendererConfig(
               writeToDisk: true,
             },
             client: {
-              overlay: {
-                errors: true,
-                warnings: false,
-              },
+              overlay:
+                process.env.DISABLE_DEVSERVER_OVERLAY === 'true'
+                  ? false
+                  : { warnings: false, errors: true, runtimeErrors: true },
             },
             https: false,
             hot: opts.hot,

configs/webpack-config-compass/src/index.ts

@@ -28,7 +28,8 @@
     "test-cov": "nyc --compact=false --produce-source-map=false -x \"**/*.spec.*\" --reporter=lcov --reporter=text --reporter=html npm run test",
     "test-watch": "npm run test -- --watch",
     "test-ci": "npm run test-cov",
-    "reformat": "npm run eslint . -- --fix && npm run prettier -- --write ."
+    "reformat": "npm run eslint . -- --fix && npm run prettier -- --write .",
+    "postinstall": "node --experimental-strip-types ./scripts/patch-leafygreen-button.js"
   },
   "dependencies": {
     "@dnd-kit/core": "^6.0.7",

package-lock.json

@@ -0,0 +1,26 @@
+/**
+ * We can't update @leafygreen-ui/button component to latest because it breaks
+ * the types across the whole application, but we also have to add a dependency
+ * on a new leafygreen package that depends on a new export from the button
+ * package, this new export is a one-liner color value. As a temporary
+ * workaround, we will patch leafygreen package and add the export manually. For
+ * more details see https://github.com/mongodb-js/compass/pull/7223
+ */
+const fs = require('fs');
+const path = require('path');
+
+const leafygreenButtonPackage = path.dirname(
+  require.resolve('@leafygreen-ui/button/package.json')
+);
+
+// eslint-disable-next-line no-console
+console.log('Adding @leafygreen-ui/button/constants export...');
+
+fs.writeFileSync(
+  path.join(leafygreenButtonPackage, 'constants.js'),
+  "export const PRIMARY_BUTTON_INTERACTIVE_GREEN = '#00593F';"
+);
+fs.writeFileSync(
+  path.join(leafygreenButtonPackage, 'constants.d.ts'),
+  'export declare const PRIMARY_BUTTON_INTERACTIVE_GREEN = "#00593F";'
+);