fix: change updateAttributes return type to boolean

Author: myang1220

packages/compass-user-data/src/user-data.ts

@@ -93,7 +93,7 @@ export abstract class IUserData<T extends z.Schema> {
   abstract updateAttributes(
     id: string,
     data: Partial<z.input<T>>
-  ): Promise<z.output<T>>;
+  ): Promise<boolean>;
 }
 
 export class FileUserData<T extends z.Schema> extends IUserData<T> {
@@ -324,12 +324,16 @@ export class FileUserData<T extends z.Schema> extends IUserData<T> {
   async updateAttributes(
     id: string,
     data: Partial<z.input<T>>
-  ): Promise<z.output<T>> {
-    await this.write(id, {
-      ...((await this.readOne(id)) ?? {}),
-      ...data,
-    });
-    return await this.readOne(id);
+  ): Promise<boolean> {
+    try {
+      await this.write(id, {
+        ...((await this.readOne(id)) ?? {}),
+        ...data,
+      });
+      return true;
+    } catch {
+      return false;
+    }
   }
 }
 
@@ -461,7 +465,7 @@ export class AtlasUserData<T extends z.Schema> extends IUserData<T> {
   async updateAttributes(
     id: string,
     data: Partial<z.input<T>>
-  ): Promise<z.output<T>> {
+  ): Promise<boolean> {
     try {
       const response = await this.authenticatedFetch(this.getUrl() + `/${id}`, {
         method: 'PUT',
@@ -475,7 +479,7 @@ export class AtlasUserData<T extends z.Schema> extends IUserData<T> {
           `Failed to update data: ${response.status} ${response.statusText}`
         );
       }
-      return this.validator.parse(data);
+      return true;
     } catch (error) {
       log.error(
         mongoLogId(1_001_000_365),
@@ -486,7 +490,7 @@ export class AtlasUserData<T extends z.Schema> extends IUserData<T> {
           error: (error as Error).message,
         }
       );
-      throw new Error('Failed to update data');
+      return false;
     }
   }
 

packages/my-queries-storage/src/compass-query-storage.ts

@@ -49,7 +49,7 @@ export abstract class CompassQueryStorage<TSchema extends z.Schema> {
   async updateAttributes(
     id: string,
     data: Partial<z.input<TSchema>>
-  ): Promise<z.output<TSchema>> {
+  ): Promise<boolean> {
     return await this.userData.updateAttributes(id, data);
   }
 

packages/my-queries-storage/src/query-storage.ts

@@ -6,7 +6,7 @@ import type {
 
 interface QueryStorage<T extends typeof RecentQuerySchema> {
   loadAll(namespace?: string): Promise<z.output<T>[]>;
-  updateAttributes(id: string, data: Partial<z.input<T>>): Promise<z.output<T>>;
+  updateAttributes(id: string, data: Partial<z.input<T>>): Promise<boolean>;
   delete(id: string): Promise<boolean>;
 }