Skip to content

Commit 32c815b

Browse files
authored
ci(tests): enable web tests for data modeling COMPASS-9470 (#7033)
* enable web tests * make flag writable on web * cleaner check
1 parent 7756845 commit 32c815b

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

packages/compass-e2e-tests/helpers/test-runner-context.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ process.env.HADRON_DISTRIBUTION ??= context.hadronDistribution;
344344
process.env.COMPASS_WEB_HTTP_PROXY_CLOUD_CONFIG ??=
345345
context.atlasCloudSandboxCloudConfig ?? 'dev';
346346

347-
if (isTestingAtlasCloudSandbox(context)) {
347+
if (isTestingWeb()) {
348348
process.env.E2E_TEST_CLOUD_WEB_ENABLE_PREFERENCE_SAVING ??= 'true';
349349
}
350350

packages/compass-e2e-tests/tests/data-modeling-tab.test.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import {
44
init,
55
cleanup,
66
screenshotIfFailed,
7-
skipForWeb,
87
DEFAULT_CONNECTION_NAME_1,
98
} from '../helpers/compass';
109
import type { Compass } from '../helpers/compass';
@@ -38,12 +37,10 @@ describe('Data Modeling tab', function () {
3837
let browser: CompassBrowser;
3938

4039
before(async function () {
41-
skipForWeb(this, 'data modeling not yet available in compass-web');
42-
4340
compass = await init(this.test?.fullTitle());
4441
browser = compass.browser;
45-
await browser.setFeature('enableDataModeling', true);
4642
await browser.setupDefaultConnections();
43+
await browser.setFeature('enableDataModeling', true);
4744
});
4845

4946
beforeEach(async function () {

packages/compass-preferences-model/src/compass-web-preferences-access.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ const editablePreferences: (keyof UserPreferences)[] = [
1717
'enableGenAISampleDocumentPassingOnAtlasProject',
1818
'enableGenAIFeaturesAtlasOrg',
1919
'enableGenAIFeaturesAtlasProject',
20+
'enableDataModeling',
2021
];
2122

2223
export class CompassWebPreferencesAccess implements PreferencesAccess {

0 commit comments

Comments
 (0)