Skip to content

Commit 3660f9d

Browse files
committed
Merge pull request #185 from 10gen/geo-transform-hoist
🐛 transform must be defined before being called
2 parents fda91c7 + 886ba49 commit 3660f9d

File tree

1 file changed

+12
-13
lines changed

1 file changed

+12
-13
lines changed

src/minicharts/d3fns/geo.js

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -251,11 +251,22 @@ var minicharts_d3fns_geo = function() {
251251
// Draw each marker as a separate SVG element.
252252
overlay.draw = function() {
253253
var layer = d3.select('div.layer');
254-
var transform;
255254

256255
projection = this.getProjection();
257256
var padding = 9;
258257

258+
var transform = function(d) {
259+
var p = new google.maps.LatLng(d[1], d[0]);
260+
p = projection.fromLatLngToDivPixel(p);
261+
d.x = p.x;
262+
d.y = p.y;
263+
var self = d3.select(this);
264+
self
265+
.style('left', p.x - padding + 'px')
266+
.style('top', p.y - padding + 'px');
267+
return self;
268+
};
269+
259270
var marker = layer.selectAll('svg.marker')
260271
.data(data)
261272
.each(transform) // update existing markers
@@ -268,18 +279,6 @@ var minicharts_d3fns_geo = function() {
268279
.attr('r', 4.5)
269280
.attr('cx', padding)
270281
.attr('cy', padding);
271-
272-
transform = function(d) {
273-
var p = new google.maps.LatLng(d[1], d[0]);
274-
p = projection.fromLatLngToDivPixel(p);
275-
d.x = p.x;
276-
d.y = p.y;
277-
var self = d3.select(this);
278-
self
279-
.style('left', p.x - padding + 'px')
280-
.style('top', p.y - padding + 'px');
281-
return self;
282-
};
283282
}; // end overlay.draw
284283

285284
overlay.setMap(googleMap);

0 commit comments

Comments
 (0)