COMPASS 156 Range Component - queryToParams (#546)

* COMPASS 156: DV - range component queryToParams

Revert "Revert "Temporarily add range rule in" so partial progress stays hidden"

This reverts commit cb9a1cc.

* Migrate validation.rule.test.js into Compass CI tests

* Move validation.store.test.js into CI tests, skipping errors

I don't understand where these are coming from, so skip them for now as it's unclear if we might want to go back to a separate shareable repo in future:

FIRST ERROR
--------------------
    ✓ goes into {fetchState: "error"} when receiving an error back
TypeError: Cannot set property 'validator' of undefined
    at Store._deconstructValidatorDoc (/Users/pzrq/Projects/compass/src/internal-packages/validation/lib/stores/index.js:81:7)
    at _fetchFromServer (/Users/pzrq/Projects/compass/src/internal-packages/validation/lib/stores/index.js:223:27)
    at Timeout._onTimeout (/Users/pzrq/Projects/compass/test/validation.store.test.js:14:14)
    at tryOnTimeout (timers.js:224:11)
    at Timer.listOnTimeout (timers.js:198:5)
TypeError: Cannot set property 'validator' of undefined
    at Store._deconstructValidatorDoc (/Users/pzrq/Projects/compass/src/internal-packages/validation/lib/stores/index.js:81:7)
    at _fetchFromServer (/Users/pzrq/Projects/compass/src/internal-packages/validation/lib/stores/index.js:223:27)
    at Timeout._onTimeout (/Users/pzrq/Projects/compass/test/validation.store.test.js:14:14)
    at tryOnTimeout (timers.js:224:11)
    at Timer.listOnTimeout (timers.js:198:5)
    1) goes into {fetchState: "error"} when receiving an invalid validator doc
Failed with exit code: 1

SECOND ERROR
-------------------------
    ✓ goes into {fetchState: "error"} when receiving an error back
    - goes into {fetchState: "error"} when receiving an invalid validator doc
TypeError: Cannot set property 'validator' of undefined
    at Store._deconstructValidatorDoc (/Users/pzrq/Projects/compass/src/internal-packages/validation/lib/stores/index.js:81:7)
    at _fetchFromServer (/Users/pzrq/Projects/compass/src/internal-packages/validation/lib/stores/index.js:223:27)
    at Timeout._onTimeout (/Users/pzrq/Projects/compass/test/validation.store.test.js:14:14)
    at tryOnTimeout (timers.js:224:11)
    at Timer.listOnTimeout (timers.js:198:5)
TypeError: Cannot set property 'validator' of undefined
    at Store._deconstructValidatorDoc (/Users/pzrq/Projects/compass/src/internal-packages/validation/lib/stores/index.js:81:7)
    at _fetchFromServer (/Users/pzrq/Projects/compass/src/internal-packages/validation/lib/stores/index.js:223:27)
    at Timeout._onTimeout (/Users/pzrq/Projects/compass/test/validation.store.test.js:14:14)
    at tryOnTimeout (timers.js:224:11)
    at Timer.listOnTimeout (timers.js:198:5)
    1) goes into {fetchState: "error"} when the result is not an object
{ AssertionError: expected 1 to equal 2
    at Timeout.setTimeout (/Users/pzrq/Projects/compass/test/validation.store.test.js:110:35)
    at tryOnTimeout (timers.js:224:11)
    at Timer.listOnTimeout (timers.js:198:5)
  message: 'expected 1 to equal 2',
  showDiff: true,
  actual: 1,
  expected: 2 }
AssertionError: expected 1 to equal 2
    at Timeout.setTimeout (/Users/pzrq/Projects/compass/test/validation.store.test.js:110:35)
    at tryOnTimeout (timers.js:224:11)
    at Timer.listOnTimeout (timers.js:198:5)
    2) "after each" hook

* Migrate range code and tests from compass-validation repo

* Refactor logic into validateKeyAndValue

Lowers the complexity of queryToParams from 14 to 12.

* Remove chained if to lower complexity

Fixes TODO.

* Drop infinity support and add some negative and decimals tests

Infinity is dropped as the empty clause is better and so we don't have to represent it in the GUI.

* Improve test context

* Get values from an existing validatorDoc shown in GUI

At a mongo shell:
use validation;
> db.runCommand({collMod: 'validation', validator: {"age": {$gte:0.01,$lt:5000 },     "phone_no": {       "$regex": "^[0-9 ]+$",       "$options": "mx"     }   }});

* Get {<, <=, >, >=, none} server validatorDoc shown in dropdown GUI

At a mongo shell:
use validation;
> db.runCommand({collMod: 'validation', validator: {"age": {$gte:0.01,$lt:5000 },     "phone_no": {       "$regex": "^[0-9 ]+$",       "$options": "mx"     }   }});

* Hide range component again and skip integration tests

Full range component to come in a JIRA linked to COMPASS-156 or COMPASS-235.

* Structure & naming things request from @rueckstiess, thanks!

* Skip things again

Coming in COMPASS-235, definitely working on that today so we can stop this back and forth partial stuff.

* Drop unnecessary skips

* fix “fetching” test, allow callback to be called once

* Fix RangeInput test warnings about missing non-default required "value"

* Drop "are not useful"

Wasn't found in earlier string replace in COMPASS-156

Author: pzrq

src/internal-packages/validation/lib/components/common/range-input.jsx

@@ -167,11 +167,11 @@ class RangeInput extends React.Component {
 }
 
 RangeInput.propTypes = {
-  value: React.PropTypes.number,
+  value: React.PropTypes.number.isRequired,
   upperBound: React.PropTypes.bool,
   validationState: React.PropTypes.string,
-  boundIncluded: React.PropTypes.bool,
-  disabled: React.PropTypes.bool,
+  boundIncluded: React.PropTypes.bool.isRequired,
+  disabled: React.PropTypes.bool.isRequired,
   onChange: React.PropTypes.func,
   width: React.PropTypes.number
 };

src/internal-packages/validation/lib/components/rule-categories/range.jsx

@@ -43,12 +43,26 @@ class RuleCategoryRange extends React.Component {
     return result;
   }
 
+  static validateKeyAndValue(key, value) {
+    if (!_.includes(['$gt', '$gte', '$lt', '$lte'], key)) {
+      return false;
+    }
+    // Check that we have only numeric (or null) types.
+    // String types are a possible extension,
+    // but documents, arrays, BinData, undefined and other BSON types
+    // make little sense http://bsonspec.org/spec.html
+    if (typeof(value) !== 'number') {
+      return false;
+    }
+    return !isNaN(value) && Math.abs(value) !== Infinity;
+  }
+
   static queryToParams(query) {
     // if not every key in the object is one of the comparison operators,
     // this rule cannot represent the query
     const keys = _.keys(query);
     if (!_.every(keys, (key) => {
-      return _.contains(['$gt', '$gte', '$lt', '$lte'], key);
+      return RuleCategoryRange.validateKeyAndValue(key, query[key]);
     })) {
       return false;
     }
@@ -58,12 +72,17 @@ class RuleCategoryRange extends React.Component {
       lowerBoundValue: query.$gte || query.$gt || null,
       lowerBoundType: _.intersection(keys, ['$gte', '$gt'])
     };
-
-    if (result.upperBoundType.length === 0) {
-      result.upperBoundType = null;
+    if (result.upperBoundType.length > 1 || result.lowerBoundType.length > 1) {
+      return false;
     }
-    if (result.lowerBoundType.length === 0) {
-      result.lowerBoundType = null;
+    result.upperBoundType = result.upperBoundType[0] || null;
+    result.lowerBoundType = result.lowerBoundType[0] || null;
+
+    // No documents could possibly satisfy these cases, e.g. 5 <= value < 5
+    if (typeof(result.upperBoundValue) === 'number' &&
+        typeof(result.lowerBoundValue) === 'number' &&
+        result.upperBoundValue <= result.lowerBoundValue) {
+      return false;
     }
     return result;
   }
@@ -76,8 +95,17 @@ class RuleCategoryRange extends React.Component {
   render() {
     return (
       <FormGroup>
-        <RangeInput />
-        <RangeInput upperBound/>
+        <RangeInput
+            boundIncluded={this.props.parameters.lowerBoundType === '$gte'}
+            disabled={this.props.parameters.lowerBoundType === null}
+            value={this.props.parameters.lowerBoundValue}
+        />
+        <RangeInput
+            upperBound
+            boundIncluded={this.props.parameters.upperBoundType === '$lte'}
+            disabled={this.props.parameters.upperBoundType === null}
+            value={this.props.parameters.upperBoundValue}
+        />
       </FormGroup>
     );
   }

test/validation.range.test.js

@@ -15,25 +15,25 @@ chai.use(chaiEnzyme());
 describe('<RangeInput />', () => {
   context('when rendering the default control', () => {
     it('has label `LOWER BOUND`', () => {
-      const component = shallow(<RangeInput />);
+      const component = shallow(<RangeInput value={5} />);
       const labelText = component.find(ControlLabel).dive().text();
       expect(labelText).to.be.equal('LOWER BOUND');
     });
     it('has placeholder text of `enter lower bound`', () => {
-      const component = shallow(<RangeInput />);
+      const component = shallow(<RangeInput value={5} />);
       const placeholderText = component.find(FormControl).props().placeholder;
       expect(placeholderText).to.be.equal('enter lower bound');
     });
   });
 
   context('when rendering an upperBound control', () => {
     it('has label `UPPER BOUND`', () => {
-      const component = shallow(<RangeInput upperBound />);
+      const component = shallow(<RangeInput upperBound value={5} />);
       const labelText = component.find(ControlLabel).dive().text();
       expect(labelText).to.be.equal('UPPER BOUND');
     });
     it('has placeholder text of `enter upper bound`', () => {
-      const component = shallow(<RangeInput upperBound />);
+      const component = shallow(<RangeInput upperBound value={5} />);
       const placeholderText = component.find(FormControl).props().placeholder;
       expect(placeholderText).to.be.equal('enter upper bound');
     });

src/internal-packages/validation/test/rule.test.js renamed to test/validation.rule.test.js

@@ -1,11 +1,11 @@
-/* eslint no-unused-expressions: 0 */
+/* eslint no-unused-vars: 0 */
 const chai = require('chai');
 const chaiEnzyme = require('chai-enzyme');
 const expect = chai.expect;
 const React = require('react');
 
 const mount = require('enzyme').mount;
-const Rule = require('../lib/components/rule');
+const Rule = require('../src/internal-packages/validation/lib/components/rule');
 const _ = require('lodash');
 
 // const debug = require('debug')('compass:validation:test');