INT-959 Open links in external browser

(cherry picked from commit b634647)

Author: rueckstiess

src/app.js

@@ -22,6 +22,7 @@ var ViewSwitcher = require('ampersand-view-switcher');
 var View = require('ampersand-view');
 var localLinks = require('local-links');
 var async = require('async');
+var shell = window.require('shell');
 
 var QueryOptions = require('./models/query-options');
 var Connection = require('./models/connection');
@@ -258,10 +259,16 @@ var Application = View.extend({
     this.pageSwitcher.set(view);
   },
   onLinkClick: function(event) {
+    debug('onLinkClick', event);
     var pathname = localLinks.getLocalPathname(event);
     if (pathname) {
       event.preventDefault();
       this.router.history.navigate(pathname);
+      return;
+    } else if (event.currentTarget.getAttribute('href') !== '#') {
+      event.preventDefault();
+      event.stopPropagation();
+      shell.openExternal(event.target.href);
     }
   }
 });
@@ -272,6 +279,37 @@ var state = new Application({
   connection_id: connectionId
 });
 
+function handleIntercomLinks() {
+  function getNodeObserver(fn) {
+    var observer = new MutationObserver(function(mutations) {
+      mutations.forEach(function(mutation) {
+        if (!mutation.addedNodes) {
+          return;
+        }
+        [].forEach.call(mutation.addedNodes, fn);
+      });
+    });
+    return observer;
+  }
+
+  var lookForLinks = getNodeObserver(function(element) {
+    if (element.nodeName === 'A') {
+      $(element).click(state.onLinkClick.bind(state));
+    }else {
+      $(element).find('a').click(state.onLinkClick.bind(state));
+    }
+  });
+
+  var waitForIntercom = getNodeObserver(function(element) {
+    if (element.id === 'intercom-container') { // if intercom is now available...
+      lookForLinks.observe(element, {childList: true, subtree: true});
+      waitForIntercom.disconnect(); // stop waiting for intercom
+    }
+  });
+
+  waitForIntercom.observe(document.body, {childList: true});
+}
+
 app.extend({
   client: null,
   config: {
@@ -301,6 +339,8 @@ app.extend({
       return;
     }
 
+    handleIntercomLinks();
+
     app.statusbar.show('Retrieving connection details...');
 
     state.connection = new Connection({

src/help/entries/dev-how-help-works.md

@@ -97,12 +97,12 @@ a help entry like so:
 ![](./images/help/my_image.png)
 ```
 
+##### External Links
+
+External links are supported and detected automatically, see for example the
+[MongoDB Manual](https://docs.mongodb.org/manual/). It should open in the user's
+default browser, not Compass.
+
 ### Known Issues
 
 - The help system currently doesn't support external links yet.
-- The help window is not yet a singleton
-- The help window is too big
-- The help window needs styling
-- The sidebar should have some hierarchy to find articles faster
-- The sidebar should have a filter at the top to find articles faster
-- The help system should be accessible from the Help menu

src/help/index.js

@@ -67,11 +67,10 @@ var HelpPage = View.extend({
     this.listenTo(app, 'show-help-entry', this.show.bind(this));
   },
   onLinkClicked: function(evt) {
-    evt.preventDefault();
-    evt.stopPropagation();
-    // @todo handle external links
     var entryId = evt.delegateTarget.hash.slice(1);
-    if (entryId) {
+    if (entryId && entries.get(entryId)) {
+      evt.preventDefault();
+      evt.stopPropagation();
       this.show(entryId);
     }
   },