Skip to content

Commit 399583d

Browse files
imlucaskangas
authored andcommitted
🏁 INT-1286: Windows control panel icon
1 parent f8c3828 commit 399583d

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

scripts/config.js

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,10 @@ exports.options = {
8383
description: 'branch_name on evergreen',
8484
type: 'string',
8585
default: undefined
86+
},
87+
favicon_url: {
88+
description: 'A URL to an ICO file to use as the application icon (e.g. Windows: displayed in Control Panel > Programs and Features)',
89+
default: 'https://raw.githubusercontent.com/mongodb-js/favicon/master/favicon.ico'
8690
}
8791
};
8892

@@ -144,6 +148,7 @@ exports.get = function(cli, callback) {
144148
InternalName: cli.argv.internal_name
145149
},
146150
images: path.join(__dirname, '..', 'src', 'app', 'images'),
151+
favicon_url: cli.argv.favicon_url,
147152
table: function() {
148153
/**
149154
* Print the assembled `CONFIG` data as a nice table.
@@ -269,14 +274,7 @@ exports.get = function(cli, callback) {
269274
* https://raw.githubusercontent.com/Squirrel/Squirrel.Windows/master/src/Setup/Setup.ico
270275
* setupIcon: WINDOWS_ICON,
271276
*/
272-
/**
273-
* TODO (imlucas) A URL to an ICO file to use as the application icon
274-
* (displayed in Control Panel > Programs and Features). Defaults
275-
* to the Atom icon.
276-
* Defaults to:
277-
* 'https://raw.githubusercontent.com/atom/electron/master/atom/browser/resources/win/atom.ico',
278-
* iconUrl: 'https://www.mongodb.org/assets/global/favicon-1d2d833bba579ce81fcff283e0fd2be6769949a54650c8558a631a03af71f7f2.ico',
279-
*/
277+
iconUrl: CONFIG.favicon_url,
280278
name: CONFIG.name,
281279
id: CONFIG.name
282280
}).then(function(res) {

0 commit comments

Comments
 (0)