COMPASS-850: Backport COMPASS 832 - Return to avoid running the success case on error of insert document (#821) (#827)

pzrq · web-flow · commit 3a7efd8734b2 · 2017-03-06T13:33:23.000+11:00
#retry "MongoDB runner - Error: socket hang up" https://travis-ci.com/10gen/compass/jobs/67360416
diff --git a/src/internal-packages/crud/lib/store/insert-document-store.js b/src/internal-packages/crud/lib/store/insert-document-store.js
@@ -26,7 +26,7 @@ const InsertDocumentStore = Reflux.createStore({
   insertDocument: function(doc) {
     app.dataService.insertOne(NamespaceStore.ns, doc, {}, (error) => {
       if (error) {
-        this.trigger(false, error);
+        return this.trigger(false, error);
       }
       const filter = _.assign(this.filter, { _id: doc._id });
       app.dataService.count(NamespaceStore.ns, filter, {}, (err, count) => {

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ const InsertDocumentStore = Reflux.createStore({`
`26`	`26`	`insertDocument: function(doc) {`
`27`	`27`	`app.dataService.insertOne(NamespaceStore.ns, doc, {}, (error) => {`
`28`	`28`	`if (error) {`
`29`		`- this.trigger(false, error);`
	`29`	`+ return this.trigger(false, error);`
`30`	`30`	`}`
`31`	`31`	`const filter = _.assign(this.filter, { _id: doc._id });`
`32`	`32`	`app.dataService.count(NamespaceStore.ns, filter, {}, (err, count) => {`