Skip to content

Commit 3ce421a

Browse files
committed
nit
1 parent 780c398 commit 3ce421a

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

packages/compass-collection/src/components/collection-header-actions/collection-header-actions.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,8 @@ const CollectionHeaderActions: React.FunctionComponent<
145145
</div>
146146
}
147147
>
148+
// todo within (CLOUDP-333853): update disabled open-modal button
149+
tooltip to communicate if schema analysis is incomplete
148150
{exceedsMaxNestingDepth &&
149151
'At this time we are unable to generate mock data for collections that have deeply nested documents'}
150152
{isCollectionEmpty &&

packages/compass-collection/src/components/mock-data-generator-modal/raw-schema-confirmation-screen.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,6 @@ const RawSchemaConfirmationScreen = ({
6161
? 'A sample of document values from your collection will be sent to an LLM for processing.'
6262
: 'We have identified the following schema from your documents. This schema will be sent to an LLM for processing.';
6363

64-
// (CLOUDP-333853) todo: disable button that opens modal and update tooltip while schema analysis is underway.
65-
// after the todo this state should not be reachable
66-
const schemaAnalysisIncompletePlaceholder = (
67-
<Body>We are analyzing your collection.</Body>
68-
);
69-
7064
return (
7165
<div data-testid="raw-schema-confirmation">
7266
{schemaAnalysis.status === 'complete' ? (
@@ -97,7 +91,8 @@ const RawSchemaConfirmationScreen = ({
9791
)}
9892
</>
9993
) : (
100-
schemaAnalysisIncompletePlaceholder
94+
// Not reachable since schema analysis must be finished before the modal can be opened
95+
<Body>We are analyzing your collection.</Body>
10196
)}
10297
</div>
10398
);

0 commit comments

Comments
 (0)