Skip to content

Commit 3e0b685

Browse files
committed
Revert "INT-1610 Disable maps feature via minimally invasive change (#434)"
This reverts commit 7ceca62.
1 parent ea4ab11 commit 3e0b685

File tree

3 files changed

+12
-19
lines changed

3 files changed

+12
-19
lines changed

src/app/models/preferences.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -250,11 +250,6 @@ var Preferences = Model.extend(storageMixin, {
250250
* returns either true or false
251251
*/
252252
isFeatureEnabled: function(feature) {
253-
// INT-1610 force maps off until we have a MapBox commercial license
254-
if (feature === 'enableMaps') {
255-
return false;
256-
}
257-
258253
// master network switch overwrites all network related features
259254
if (['enableMaps', 'trackErrors', 'enableFeedbackPanel',
260255
'trackUsageStatistics', 'autoUpdates'].indexOf(feature) !== -1) {

src/app/network-optin/index.jade

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,11 @@
1313
span Enable Product Feedback Tool
1414
p.option-description Enables a tool for sending feedback or talking to our Product and Development teams directly from Compass.
1515

16-
// INT-1610 force maps off until we have a MapBox commercial license
17-
//- li
18-
//- label
19-
//- input(type='checkbox', name='enableMaps', data-hook='enable-maps-checkbox')
20-
//- span Enable Geographic Visualizations
21-
//- p.option-description Allow Compass to make requests to a 3rd party mapping service.
16+
li
17+
label
18+
input(type='checkbox', name='enableMaps', data-hook='enable-maps-checkbox')
19+
span Enable Geographic Visualizations
20+
p.option-description Allow Compass to make requests to a 3rd party mapping service.
2221

2322
li
2423
label

src/app/network-optin/index.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ var NetworkOptInView = View.extend({
1717
trackErrors: ['boolean', true, true],
1818
enableFeedbackPanel: ['boolean', true, true],
1919
trackUsageStatistics: ['boolean', true, true],
20-
autoUpdates: ['boolean', true, true]
21-
// enableMaps: ['boolean', true, true]
20+
autoUpdates: ['boolean', true, true],
21+
enableMaps: ['boolean', true, true]
2222
},
2323
session: {
2424
preferences: 'state',
@@ -53,12 +53,11 @@ var NetworkOptInView = View.extend({
5353
hook: 'usage-stats-checkbox',
5454
name: 'checked'
5555
},
56-
// INT-1610 force maps off until we have a MapBox commercial license
57-
// enableMaps: {
58-
// type: 'booleanAttribute',
59-
// hook: 'enable-maps-checkbox',
60-
// name: 'checked'
61-
// },
56+
enableMaps: {
57+
type: 'booleanAttribute',
58+
hook: 'enable-maps-checkbox',
59+
name: 'checked'
60+
},
6261
buttonTitle: {
6362
hook: 'start-button'
6463
}

0 commit comments

Comments
 (0)