chore(eslint): re-enable no-unused-vars for catch blocks; re-enable no-redundant-type-constituents and clean up redundant COMPASS-9459 (#7023)

chore(eslint): re-enable no-unused-vars for catch statements; re-enable no-redundant-type-constituents and clean up redundant

Author: gribnoysup

configs/eslint-config-compass/index.js

@@ -25,13 +25,6 @@ const extraTsRules = {
   // clean those out and re-enable the rules
   '@typescript-eslint/no-explicit-any': 'warn',
   '@typescript-eslint/no-base-to-string': 'warn',
-  '@typescript-eslint/no-unused-vars': [
-    'error',
-    {
-      caughtErrors: 'none', // should be `'all'`
-    },
-  ],
-  '@typescript-eslint/no-redundant-type-constituents': 'warn',
   '@typescript-eslint/unbound-method': 'warn',
   '@typescript-eslint/no-duplicate-type-constituents': 'warn',
   '@typescript-eslint/no-unsafe-declaration-merging': 'warn',

configs/webpack-config-compass/src/util.ts

@@ -38,7 +38,7 @@ export function entriesToHtml(
           fs.statSync(maybeTemplatePath);
           template = maybeTemplatePath;
           break;
-        } catch (e) {
+        } catch {
           // ignore and use default template, electron renderer entry will need
           // at least some kind of html page provided one way or the other
         }

packages/atlas-service/src/main.ts

@@ -244,7 +244,7 @@ export class CompassAuthService {
     throwIfAborted(signal);
     try {
       return (await this.introspect({ signal })).active;
-    } catch (err) {
+    } catch {
       return false;
     }
   }

packages/atlas-service/src/store/atlas-signin-reducer.ts

@@ -278,7 +278,7 @@ export const restoreSignInState = (): AtlasSignInThunkAction<Promise<void>> => {
       } else {
         dispatch({ type: AtlasSignInActions.RestoringFailed });
       }
-    } catch (err) {
+    } catch {
       // For the initial state check if failed to check auth for any reason we
       // will just allow user to sign in again, ignoring the error
       dispatch({ type: AtlasSignInActions.RestoringFailed });

packages/compass-aggregations/src/modules/count-documents.ts

@@ -132,7 +132,7 @@ export const countDocuments = (): PipelineBuilderThunkAction<Promise<void>> => {
         type: ActionTypes.CountFinished,
         count: Number(count),
       });
-    } catch (e) {
+    } catch {
       dispatch({
         type: ActionTypes.CountFailed,
       });

packages/compass-aggregations/src/modules/insights.ts

@@ -97,7 +97,7 @@ export const fetchExplainForPipeline = (): PipelineBuilderThunkAction<
       const explainPlan = new ExplainPlan(rawExplainPlan as Stage);
       dispatch({ type: FETCH_EXPLAIN_PLAN_SUCCESS, explainPlan });
       ExplainFetchAbortControllerMap.delete(id);
-    } catch (err) {
+    } catch {
       // We are only fetching this to get information about index usage for
       // insight badge, if this fails for any reason: server, cancel, error
       // getting pipeline from state, or parsing explain plan. Whatever it is,

packages/compass-aggregations/src/modules/pipeline-builder/pipeline-builder.ts

@@ -96,7 +96,7 @@ export class PipelineBuilder {
       if (!Array.isArray(this.pipeline)) {
         throw new Error('Pipeline should be an array');
       }
-    } catch (e) {
+    } catch {
       this.pipeline = null;
     }
   }

packages/compass-aggregations/src/modules/pipeline-builder/pipeline-parser/stage-parser.ts

@@ -26,7 +26,7 @@ export function isValidStageNode(node?: t.ObjectExpression): boolean {
       // before validating it again
       parseShellBSON(generate(node));
       return true;
-    } catch (err) {
+    } catch {
       return false;
     }
   }

packages/compass-aggregations/src/modules/pipeline-builder/stage-editor.ts

@@ -886,13 +886,13 @@ const formatWizardValue = (value?: string): string => {
   let reIndented = value;
   try {
     reIndented = JSON.stringify(JSON.parse(value), null, 2);
-  } catch (e) {
+  } catch {
     // not valid json
   }
 
   try {
     return prettify(reIndented);
-  } catch (e) {
+  } catch {
     // not valid js (ie. the generated stage has placeholders for the user to fill etc ..)
     return reIndented;
   }

packages/compass-aggregations/src/modules/search-indexes.ts

@@ -109,7 +109,7 @@ export const fetchIndexes = (): PipelineBuilderThunkAction<Promise<void>> => {
         type: ActionTypes.FetchIndexesFinished,
         indexes,
       });
-    } catch (e) {
+    } catch {
       dispatch({
         type: ActionTypes.FetchIndexesFailed,
       });