fix my queries storage package check

Author: nvs119

packages/my-queries-storage/src/base-pipeline-storage.ts

@@ -1,20 +1,21 @@
-import { type IUserData } from '@mongodb-js/compass-user-data';
-import { PipelineSchema } from './pipeline-storage-schema';
+import type { IUserData, z } from '@mongodb-js/compass-user-data';
 import type { SavedPipeline } from './pipeline-storage-schema';
 import type { PipelineStorageInterface } from './storage-interfaces';
 
 // Generic base class for pipeline storage that works with any IUserData implementation
-export class BaseCompassPipelineStorage implements PipelineStorageInterface {
-  private readonly userData: IUserData<typeof PipelineSchema>;
-  
-  constructor(userData: IUserData<typeof PipelineSchema>) {
+export class BaseCompassPipelineStorage<TSchema extends z.Schema>
+  implements PipelineStorageInterface
+{
+  private readonly userData: IUserData<TSchema>;
+
+  constructor(userData: IUserData<TSchema>) {
     this.userData = userData;
   }
 
   async loadAll(): Promise<SavedPipeline[]> {
     try {
       const { data } = await this.userData.readAll();
-      return data;
+      return data as SavedPipeline[];
     } catch {
       return [];
     }

packages/my-queries-storage/src/base-query-storage.ts

@@ -1,4 +1,4 @@
-import { ObjectId, UUID } from 'bson';
+import { UUID } from 'bson';
 import { type z } from '@mongodb-js/compass-user-data';
 import { type IUserData } from '@mongodb-js/compass-user-data';
 import { RecentQuerySchema, FavoriteQuerySchema } from './query-storage-schema';
@@ -9,8 +9,8 @@ import type {
 
 // Generic storage options that can be extended by platform-specific implementations
 export type BaseStorageOptions = {
-  serialize?: (content: any) => string;
-  deserialize?: (content: string) => any;
+  serialize?: (content: unknown) => string;
+  deserialize?: (content: string) => unknown;
 };
 
 // Generic base class that works with any IUserData implementation

packages/my-queries-storage/src/compass-pipeline-storage.spec.ts

@@ -10,7 +10,10 @@ const getEnsuredFilePath = async (tmpDir: string, fileId: string) => {
   return path.join(tmpDir, 'SavedPipelines', `${fileId}.json`);
 };
 
-const createPipeline = async (tmpDir: string, data: any) => {
+const createPipeline = async (
+  tmpDir: string,
+  data: { id: string; name: string; namespace: string }
+) => {
   const filePath = await getEnsuredFilePath(tmpDir, data.id);
   await fs.writeFile(filePath, JSON.stringify(data));
 };
@@ -84,7 +87,7 @@ describe('CompassPipelineStorage', function () {
       await fs.access(await getEnsuredFilePath(tmpDir, data.id));
       expect.fail('Expected file to not exist');
     } catch (e) {
-      expect((e as any).code).to.equal('ENOENT');
+      expect((e as NodeJS.ErrnoException).code).to.equal('ENOENT');
     }
 
     const result = await pipelineStorage.createOrUpdate(data.id, data);

packages/my-queries-storage/src/pipeline-storage-schema.ts

@@ -44,11 +44,19 @@ function savedPipelineToText(pipeline?: StoredLegacyPipelineStage[]): string {
 }
 
 export const PipelineSchema = z.preprocess(
-  (val: any) => {
-    const { pipeline: legacyPipelineArray, pipelineText, ...rest } = val;
+  (val: unknown) => {
+    const {
+      pipeline: legacyPipelineArray,
+      pipelineText,
+      ...rest
+    } = val as Record<string, unknown>;
     return {
       ...rest,
-      pipelineText: pipelineText ?? savedPipelineToText(legacyPipelineArray),
+      pipelineText:
+        pipelineText ??
+        savedPipelineToText(
+          legacyPipelineArray as StoredLegacyPipelineStage[] | undefined
+        ),
     };
   },
   z.object({

packages/my-queries-storage/src/storage-factories.ts

@@ -52,7 +52,7 @@ export function createWebPipelineStorage(options: WebStorageOptions) {
     serialize: (content) => EJSON.stringify(content),
     deserialize: (content: string) => EJSON.parse(content),
   });
-  return new BaseCompassPipelineStorage(userData);
+  return new BaseCompassPipelineStorage<typeof PipelineSchema>(userData);
 }
 
 // Electron-specific factory functions
@@ -88,5 +88,5 @@ export function createElectronPipelineStorage(
   const userData = new FileUserData(PipelineSchema, 'SavedPipelines', {
     basePath: options.basepath,
   });
-  return new BaseCompassPipelineStorage(userData);
+  return new BaseCompassPipelineStorage<typeof PipelineSchema>(userData);
 }