fixup! fixup! fixup! Add a new test

Revert the shared helper

Author: kraenhansen

configs/testing-library-compass/src/index.tsx

@@ -732,17 +732,6 @@ const testingLibrary = {
   renderHook,
 };
 
-/**
- * Expects an element (queried test id) to visible or missing from the screen
- */
-function expectElementByTestId(testId: string, state: 'visible' | 'missing') {
-  if (state === 'visible') {
-    expect(screen.queryByTestId(testId)).to.be.visible;
-  } else if (state === 'missing') {
-    expect(screen.queryByTestId(testId)).to.be.null;
-  }
-}
-
 export {
   // There is never a good reason not to have these wrapper providers when
   // rendering something in compass for testing. Using these render methods
@@ -767,5 +756,4 @@ export {
   within,
   fireEvent,
   testingLibrary,
-  expectElementByTestId,
 };

packages/compass-sidebar/src/components/multiple-connections/sidebar.spec.tsx

@@ -361,28 +361,31 @@ describe('Multiple Connections Sidebar Component', function () {
         it('should render the only connected connections when toggled', async () => {
           await renderAndWaitForNavigationTree();
 
+          const favoriteConnectionId = savedFavoriteConnection.id;
+          const recentConnectionId = savedRecentConnection.id;
+
           const activeConnectionsToggleButton = screen.getByLabelText(
             'Showing all connections'
           );
 
-          expectElementByTestId(savedFavoriteConnection.id, 'visible');
-          expectElementByTestId(savedRecentConnection.id, 'visible');
+          expect(screen.queryByTestId(favoriteConnectionId)).to.be.visible;
+          expect(screen.queryByTestId(recentConnectionId)).to.be.visible;
 
           userEvent.click(activeConnectionsToggleButton);
           expect(activeConnectionsToggleButton.ariaLabel).equals(
             'Showing active connections'
           );
 
-          expectElementByTestId(savedFavoriteConnection.id, 'missing');
-          expectElementByTestId(savedRecentConnection.id, 'missing');
+          expect(screen.queryByTestId(favoriteConnectionId)).to.be.null;
+          expect(screen.queryByTestId(recentConnectionId)).to.be.null;
 
           await connectAndNotifyInstanceManager(savedFavoriteConnection);
-          expectElementByTestId(savedFavoriteConnection.id, 'visible');
-          expectElementByTestId(savedRecentConnection.id, 'missing');
+          expect(screen.queryByTestId(favoriteConnectionId)).to.be.visible;
+          expect(screen.queryByTestId(recentConnectionId)).to.be.null;
 
           await connectAndNotifyInstanceManager(savedRecentConnection);
-          expectElementByTestId(savedFavoriteConnection.id, 'visible');
-          expectElementByTestId(savedRecentConnection.id, 'visible');
+          expect(screen.queryByTestId(favoriteConnectionId)).to.be.visible;
+          expect(screen.queryByTestId(recentConnectionId)).to.be.visible;
         });
 
         context('and performing actions', function () {