Merge pull request #381 from 10gen/fix-help-dialog

imlucas · imlucas · commit 45c7a4f7b11e · 2016-05-02T16:53:10.000-04:00
Fixing the help dialog events
diff --git a/src/app/index.js b/src/app/index.js
@@ -169,7 +169,7 @@ var Application = View.extend({
       url += '/' + id;
     }
 
-    ipc.call('app:open-url', id);
+    ipc.call('app:show-help-window', id);
   },
   onClientReady: function() {
     debug('Client ready! Took %dms to become readable',
diff --git a/src/main/window-manager.js b/src/main/window-manager.js
@@ -177,7 +177,7 @@ function showAboutDialog() {
   });
 }
 
-function showHelpWindow(id) {
+function showHelpWindow(win, id) {
   if (helpWindow) {
     helpWindow.focus();
     if (_.isString(id)) {

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ var Application = View.extend({`
`169`	`169`	`url += '/' + id;`
`170`	`170`	`}`
`171`	`171`
`172`		`- ipc.call('app:open-url', id);`
	`172`	`+ ipc.call('app:show-help-window', id);`
`173`	`173`	`},`
`174`	`174`	`onClientReady: function() {`
`175`	`175`	`debug('Client ready! Took %dms to become readable',`
Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ function showAboutDialog() {`
`177`	`177`	`});`
`178`	`178`	`}`
`179`	`179`
`180`		`-function showHelpWindow(id) {`
	`180`	`+function showHelpWindow(win, id) {`
`181`	`181`	`if (helpWindow) {`
`182`	`182`	`helpWindow.focus();`
`183`	`183`	`if (_.isString(id)) {`