Skip to content

Commit 4745f51

Browse files
committed
fixup: e2e test close toast
1 parent 2bf2a96 commit 4745f51

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

packages/compass-e2e-tests/helpers/commands/set-validation.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@ export async function setValidation(
1515

1616
await browser.clickVisible(Selectors.UpdateValidationButton);
1717

18+
// Close toast.
19+
await browser.clickVisible(
20+
Selectors.closeToastButton(Selectors.ValidationSuccessToast)
21+
);
22+
1823
// both buttons should become hidden if it succeeds
1924
await validationActionMessageElement.waitForDisplayed({
2025
reverse: true,

packages/compass-e2e-tests/helpers/selectors.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1149,6 +1149,8 @@ export const ValidationActionMessage =
11491149
'[data-testid="validation-action-message"]';
11501150
export const UpdateValidationButton =
11511151
'[data-testid="update-validation-button"]';
1152+
export const ValidationSuccessToast =
1153+
'[data-testid="toast-schema-validation-update"]';
11521154
export const ValidationMatchingDocumentsPreview =
11531155
'[data-testid="validation-content"] [data-testid="matching-documents"] [data-testid="document-preview"]';
11541156
export const ValidationLoadMatchingDocumentsBtn = `${ValidationMatchingDocumentsPreview} [data-testid="load-sample-document"]`;

packages/compass-schema-validation/src/modules/validation.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,8 @@ export function validationFromCollection(
451451
};
452452
}
453453

454+
const toastId = 'schema-validation-update';
455+
454456
/**
455457
* Save validation.
456458
*/
@@ -487,7 +489,6 @@ export const saveValidation = (
487489
}
488490
);
489491
dispatch(fetchValidation(namespace));
490-
const toastId = `schema-validation-update-${new ObjectId().toString()}`;
491492
openToast(toastId, {
492493
title: 'New validation rules applied',
493494
variant: 'success',

0 commit comments

Comments
 (0)