Propagate isEndOfLife via BuildInfo on data-service instance

Author: kraenhansen

packages/data-service/src/instance-detail-helper.spec.ts

@@ -7,6 +7,8 @@ import {
   getDatabasesByRoles,
   getPrivilegesByDatabaseAndCollection,
   getInstance,
+  isEndOfLifeVersion,
+  adaptBuildInfo,
 } from './instance-detail-helper';
 
 import * as fixtures from '../test/fixtures';
@@ -629,4 +631,53 @@ describe('instance-detail-helper', function () {
       ).to.deep.equal(['aws', 'local']);
     });
   });
+
+  describe('isEndOfLifeVersion', function () {
+    it('returns true for v4.4 and below', () => {
+      expect(isEndOfLifeVersion('4.4.0')).to.equal(true);
+      expect(isEndOfLifeVersion('4.3.0')).to.equal(true);
+      expect(isEndOfLifeVersion('4.0')).to.equal(true);
+      expect(isEndOfLifeVersion('4.0-beta.0')).to.equal(true);
+      expect(isEndOfLifeVersion('1.0.0')).to.equal(true);
+      expect(isEndOfLifeVersion('0.0.1')).to.equal(true);
+      expect(isEndOfLifeVersion('3.999.0')).to.equal(true);
+    });
+
+    it('returns true for v4.5 and above', () => {
+      expect(isEndOfLifeVersion('4.5.0')).to.equal(false);
+      expect(isEndOfLifeVersion('5.0.0')).to.equal(false);
+      expect(isEndOfLifeVersion('5.0.25')).to.equal(false);
+      expect(isEndOfLifeVersion('6.0.0')).to.equal(false);
+      expect(isEndOfLifeVersion('7.0.0')).to.equal(false);
+      expect(isEndOfLifeVersion('8.0.0')).to.equal(false);
+    });
+  });
+
+  describe('adaptBuildInfo', function () {
+    it('propagate isEndOfLife as expected', function () {
+      expect(adaptBuildInfo({ version: '4.4.0' })).to.deep.equal({
+        version: '4.4.0',
+        isEndOfLife: true,
+        isEnterprise: false,
+      });
+      // Missing version
+      expect(adaptBuildInfo({})).to.deep.equal({
+        version: '',
+        isEndOfLife: false,
+        isEnterprise: false,
+      });
+      // Malformed version
+      expect(adaptBuildInfo({ version: 'what?' })).to.deep.equal({
+        version: 'what?',
+        isEndOfLife: false,
+        isEnterprise: false,
+      });
+      // Newer version
+      expect(adaptBuildInfo({ version: '8.0.0' })).to.deep.equal({
+        version: '8.0.0',
+        isEndOfLife: false,
+        isEnterprise: false,
+      });
+    });
+  });
 });

packages/data-service/src/instance-detail-helper.ts

@@ -28,6 +28,7 @@ import { debug } from './logger';
 
 type BuildInfoDetails = {
   isEnterprise: boolean;
+  isEndOfLife: boolean;
   version: string;
 };
 
@@ -350,11 +351,23 @@ function adaptHostInfo(rawHostInfo: Partial<HostInfo>): HostInfoDetails {
   };
 }
 
-function adaptBuildInfo(rawBuildInfo: Partial<BuildInfo>) {
+export function isEndOfLifeVersion(version: string) {
+  try {
+    const [major, minor] = version.split('.').map((part) => parseInt(part, 10));
+    return (major === 4 && minor <= 4) || major < 4;
+  } catch {
+    return false;
+  }
+}
+
+export function adaptBuildInfo(rawBuildInfo: Partial<BuildInfo>) {
   return {
     version: rawBuildInfo.version ?? '',
     // Cover both cases of detecting enterprise module, see SERVER-18099.
     isEnterprise: isEnterprise(rawBuildInfo),
+    isEndOfLife: rawBuildInfo.version
+      ? isEndOfLifeVersion(rawBuildInfo.version)
+      : false,
   };
 }