Skip to content

Commit 4e4ad34

Browse files
committed
fix e2e tests
1 parent 40ae190 commit 4e4ad34

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

packages/compass-e2e-tests/helpers/selectors.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1447,13 +1447,13 @@ export const DataModelPreviewCollection = (collectionId: string) =>
14471447
`${DataModelPreview} [data-nodeid="${collectionId}"]`;
14481448
export const DataModelApplyEditor = `${DataModelEditor} [data-testid="apply-editor"]`;
14491449
export const DataModelEditorApplyButton = `${DataModelApplyEditor} [data-testid="apply-button"]`;
1450-
export const DataModelDownloadButton = 'button[aria-label="Download"]';
14511450
export const DataModelUndoButton = 'button[aria-label="Undo"]';
14521451
export const DataModelRedoButton = 'button[aria-label="Redo"]';
14531452
export const DataModelExportButton = 'button[aria-label="Export"]';
14541453
export const DataModelExportModal = '[data-testid="export-diagram-modal"]';
14551454
export const DataModelExportPngOption = `${DataModelExportModal} input[aria-label="PNG"]`;
14561455
export const DataModelExportJsonOption = `${DataModelExportModal} input[aria-label="JSON"]`;
1456+
export const DataModelExportDiagramOption = `${DataModelExportModal} input[aria-label="Diagram File"]`;
14571457
export const DataModelExportModalConfirmButton =
14581458
'[data-testid="export-button"]';
14591459
export const DataModelsListItem = (diagramName?: string) => {

packages/compass-e2e-tests/tests/data-modeling-tab.test.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,7 @@ describe('Data Modeling tab', function () {
386386
expect(text).to.include('String string'.toLowerCase());
387387
});
388388

389-
it('downloads the data model and opens it', async function () {
389+
it('exports the data model to compass format and imports it back', async function () {
390390
const dataModelName = 'Test Export Model - Save-Open';
391391
exportFileName = `${dataModelName}.compass`;
392392
await setupDiagram(browser, {
@@ -406,8 +406,12 @@ describe('Data Modeling tab', function () {
406406

407407
await browser.waitForAnimations(dataModelEditor);
408408

409-
await browser.clickVisible(Selectors.DataModelDownloadButton);
410-
await browser.waitForAnimations(dataModelEditor);
409+
await browser.clickVisible(Selectors.DataModelExportButton);
410+
const exportModal = browser.$(Selectors.DataModelExportModal);
411+
await exportModal.waitForDisplayed();
412+
413+
await browser.clickParent(Selectors.DataModelExportDiagramOption);
414+
await browser.clickVisible(Selectors.DataModelExportModalConfirmButton);
411415

412416
const { fileExists, filePath } = await waitForFileDownload(
413417
exportFileName,

0 commit comments

Comments
 (0)