chore(eslint-config): update typescript-eslint to latest (#7010)

Author: gribnoysup

.github/workflows/update-eslint.yaml

@@ -38,7 +38,10 @@ jobs:
 
       - name: Bump eslint
         run: |
-          npm i --save eslint@8 -w @mongodb-js/eslint-config-compass
+          npm i --save --workspace @mongodb-js/eslint-config-compass \
+              eslint@8 \
+              @typescript-eslint/eslint-plugin@latest \
+              @typescript-eslint/parser@latest
 
       - name: Create Pull Request
         uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # 7.0.5

configs/eslint-config-compass/index.js

@@ -15,6 +15,29 @@ const extraTsRules = {
     'error',
     { fixMixedExportsWithInlineTypeSpecifier: false },
   ],
+  '@typescript-eslint/prefer-promise-reject-errors': 'off',
+  '@typescript-eslint/only-throw-error': 'off',
+
+  // TODO: a lot new hits with latest typescript-eslint, we should gradually
+  // clean those out and re-enable the rules
+  '@typescript-eslint/no-explicit-any': 'warn',
+  '@typescript-eslint/no-base-to-string': 'warn',
+  '@typescript-eslint/no-require-imports': 'warn',
+  '@typescript-eslint/no-unused-vars': [
+    'error',
+    {
+      caughtErrors: 'none', // should be `'all'`
+    },
+  ],
+  '@typescript-eslint/no-unused-expressions': 'off', // replace with eslint-plugin-chai-friendly
+  '@typescript-eslint/no-redundant-type-constituents': 'warn',
+  '@typescript-eslint/unbound-method': 'warn',
+  '@typescript-eslint/no-duplicate-type-constituents': 'warn',
+  '@typescript-eslint/no-unsafe-declaration-merging': 'warn',
+  '@typescript-eslint/no-floating-promises': 'warn',
+  '@typescript-eslint/no-unsafe-enum-comparison': 'warn',
+  '@typescript-eslint/no-misused-promises': 'warn',
+  '@typescript-eslint/no-duplicate-enum-values': 'warn',
 };
 
 const tsRules = {
@@ -50,7 +73,7 @@ const commonTestOverrides = {
     {
       patterns: [
         {
-          group: '@testing-library/*',
+          group: ['@testing-library/*'],
           message: 'Use @mongodb-js/testing-library-compass instead',
           allowTypeImports: false,
         },

configs/eslint-config-compass/package.json

@@ -18,8 +18,8 @@
     "@babel/eslint-parser": "^7.14.3",
     "@mongodb-js/eslint-config-devtools": "^0.9.9",
     "@mongodb-js/eslint-plugin-compass": "^1.2.9",
-    "@typescript-eslint/eslint-plugin": "^5.59.0",
-    "@typescript-eslint/parser": "^5.59.0",
+    "@typescript-eslint/eslint-plugin": "^8.34.0",
+    "@typescript-eslint/parser": "^8.34.0",
     "eslint": "^8.57.1",
     "eslint-config-prettier": "^8.3.0",
     "eslint-plugin-filename-rules": "^1.2.0",

configs/eslint-config-compass/plugin.js

@@ -10,28 +10,51 @@ function restrictedProviderImport(servicePkg) {
   };
 }
 
+// node built-ins with meaningful polyfills in web environment
+const allowedNodeJSBuiltinModules = ['assert', 'stream', 'events'];
+
 module.exports = {
   ...baseConfig,
   rules: {
     ...baseConfig.rules,
     'no-restricted-imports': 'off',
     '@typescript-eslint/no-restricted-imports': [
       'error',
-      restrictedProviderImport('@mongodb-js/compass-logging'),
-      restrictedProviderImport('@mongodb-js/compass-telemetry'),
-      restrictedProviderImport('@mongodb-js/compass-app-stores'),
-      restrictedProviderImport('@mongodb-js/my-queries-storage'),
-      restrictedProviderImport('@mongodb-js/atlas-service'),
-      restrictedProviderImport('compass-preferences-model'),
-      {
-        paths: require('module').builtinModules,
-        message: 'Using Node.js built-in modules in plugins is not allowed.',
-        allowTypeImports: false,
-      },
       {
-        paths: ['electron', '@electron/remote'],
-        message: 'Using electron modules in plugins is not allowed.',
-        allowTypeImports: false,
+        paths: [
+          restrictedProviderImport('@mongodb-js/compass-logging'),
+          restrictedProviderImport('@mongodb-js/compass-telemetry'),
+          restrictedProviderImport('@mongodb-js/compass-app-stores'),
+          restrictedProviderImport('@mongodb-js/my-queries-storage'),
+          restrictedProviderImport('@mongodb-js/atlas-service'),
+          restrictedProviderImport('compass-preferences-model'),
+          ...require('module')
+            .builtinModules.filter((module) => {
+              return (
+                !module.startsWith('_') &&
+                !allowedNodeJSBuiltinModules.includes(module)
+              );
+            })
+            .flatMap((name) => {
+              const config = {
+                message:
+                  'Using Node.js built-in modules in plugins is not allowed.',
+                allowTypeImports: true,
+              };
+
+              return [
+                { name, ...config },
+                { name: `node:${name}`, ...config },
+              ];
+            }),
+          ...['electron', '@electron/remote'].map((name) => {
+            return {
+              name,
+              message: 'Using electron modules in plugins is not allowed.',
+              allowTypeImports: false,
+            };
+          }),
+        ],
       },
     ],
   },