fixup: naming, types, comments

Author: Anemy

packages/compass-collection/src/plugin-tab-title.tsx

@@ -90,8 +90,6 @@ function _PluginTitle({
 }
 
 const ConnectedPluginTitle = connect((state: CollectionState) => ({
-  // TODO: Need to check the implications of moving this metadata here
-  // instead of having it passed from the workspaces store.
   isTimeSeries: state.metadata?.isTimeSeries,
   isReadonly: state.metadata?.isReadonly,
   sourceName: state.metadata?.sourceName,

packages/compass-components/src/components/workspace-tabs/tab.tsx

@@ -149,7 +149,6 @@ const draggingTabStyles = css({
   cursor: 'grabbing !important',
 });
 
-// TODO: Should this have a dark mode version?
 const nonExistentStyles = css({
   color: palette.gray.base,
 });

packages/compass-workspaces/src/components/workspaces.tsx

@@ -131,14 +131,14 @@ const CompassWorkspaces: React.FunctionComponent<CompassWorkspacesProps> = ({
       let isNonExistent: boolean | undefined;
       if ('isNonExistent' in tab && tab.isNonExistent) {
         if (tab.type === 'Collections') {
-          // TODO: Can/should we move this logic into the collections plugin title?
+          // TODO(COMPASS-9456): Move this logic and `isNonExistent` setting to the plugin.
           const database = tab.namespace;
           const namespaceId = `${tab.connectionId}.${database}`;
           const { isNonExistent: databaseDoesNotExist } =
             databaseInfo[namespaceId] ?? {};
           isNonExistent = databaseDoesNotExist;
         } else if (tab.type === 'Collection') {
-          // TODO: Can/should we move this logic into the collection plugin title?
+          // TODO(COMPASS-9456): Move this logic and `isNonExistent` setting to the plugin.
           const { ns } = toNS(tab.namespace);
           const namespaceId = `${tab.connectionId}.${ns}`;
           const { isNonExistent: collectionDoesNotExist } =
@@ -193,15 +193,25 @@ const CompassWorkspaces: React.FunctionComponent<CompassWorkspacesProps> = ({
             >
               <Provider>
                 <WorkspaceTabContent
-                  {...(tab as any)} // TODO: This typing.
+                  // Cast to any as it can be any of the workspace types
+                  // here.
+                  {...(tab as any)}
                 />
               </Provider>
             </WorkspaceTabContextProvider>
           </ErrorBoundary>
         ),
       };
     });
-  }, [getWorkspacePlugins, tabs, getThemeOf, getConnectionById]);
+  }, [
+    getWorkspacePlugins,
+    tabs,
+    log,
+    getThemeOf,
+    mongoLogId,
+    onNamespaceNotFound,
+    getConnectionById,
+  ]);
 
   const workspaceTabContent = workspaceTabs[activeTabIndex]?.content ?? null;
 

packages/compass-workspaces/src/types.ts

@@ -104,15 +104,16 @@ export type WorkspacePluginProps<T extends AnyWorkspace['type']> = Omit<
 
 export type WorkspacePlugin<T extends AnyWorkspace['type']> = {
   name: T;
-  // TODO: Type the services and activate if we can.
-  // provider: HadronPluginComponent<T, Record<string, () => unknown>, any>;
-  provider: HadronPluginComponent<WorkspacePluginProps<T>, any, any>;
+  provider: HadronPluginComponent<
+    WorkspacePluginProps<T>,
+    Record<string, () => unknown>,
+    any
+  >;
   content:
     | React.ComponentClass<WorkspacePluginProps<T>>
     | ((props: WorkspacePluginProps<T>) => React.ReactElement | null);
   header: (props: {
     tabProps: WorkspaceTabCoreProps;
-    workspaceProps: any;
-    // workspaceProps: WorkspacePluginProps<T> // TODO: Typing
+    workspaceProps: WorkspaceTabProps;
   }) => ReturnType<typeof Tab>;
 };