Skip to content

Commit 51b9327

Browse files
authored
fix(import): COMPASS-4164: Preview table values always strings (#1914)
mongodb-js/compass-import-export#120 ## Description (wasn't handling `Date` properly in example @mmarcon had on COMPASS-4164) From mongodb-js/compass-import-export#120 > - chore: Upgrade to javascript-stringify@2 b5bdc7b Fixes #56 > - fix(import): Preview table values always strings 29148cd Fixes COMPASS-4164 > - fix(import): Hard limit reading fs for preview to first 20kb so preview always shows as fast as possible. > > ![Screenshot 2020-03-09 12 18 44](https://user-images.githubusercontent.com/23074/76234690-6f985e00-6200-11ea-86a7-e902b2d0510f.png) As a reminder, because we're now using a streaming backend, the total number of documents is likely to be off, especially for very large imports. So, 100% progress but still running is expected behavior. Devtools will log not only the input options that user chose but the estimator details as well: ![Screenshot 2020-03-09 12 40 32](https://user-images.githubusercontent.com/23074/76236618-580ea480-6203-11ea-89b9-1f91af4256a3.png) Summary stats are also logged when the import completes successfully, by user selection or error: ![Screenshot 2020-03-09 12 41 20](https://user-images.githubusercontent.com/23074/76236622-593fd180-6203-11ea-9d29-a1eded665b11.png) ![Screenshot 2020-03-09 12 45 25](https://user-images.githubusercontent.com/23074/76236992-e4b96280-6203-11ea-8e4a-af6faf5214e0.png)
1 parent ad4dcf4 commit 51b9327

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@
306306
"@mongodb-js/compass-field-store": "^6.0.3",
307307
"@mongodb-js/compass-find-in-page": "^2.0.4",
308308
"@mongodb-js/compass-home": "^4.1.1",
309-
"@mongodb-js/compass-import-export": "^5.1.8",
309+
"@mongodb-js/compass-import-export": "^5.1.9",
310310
"@mongodb-js/compass-indexes": "^3.0.9",
311311
"@mongodb-js/compass-instance": "^2.0.3",
312312
"@mongodb-js/compass-loading": "^1.0.7",

0 commit comments

Comments
 (0)