Skip to content

Commit 544a84c

Browse files
committed
chore: remove Atlas Sign-In logic COMPASS-9595
Since we're removing the signin requirement from the AI features we do not hacve any components in need of the Atlas sign-in flows. As it's also built using a pattern we have deviated from, it's best to remove it now and re-add it through a different structure later if needed.
1 parent 3df8f4a commit 544a84c

File tree

17 files changed

+1
-1485
lines changed

17 files changed

+1
-1485
lines changed

docs/security-test-summary.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@ including the specific instances listed below.
77

88
# Security Tests
99

10-
## Atlas Login Integration Tests
11-
12-
The Atlas Login feature is thoroughly tested, including proper authentication token
13-
handling and credential revocation upon signout.
14-
1510
<!-- Source File: `packages/atlas-service/src/main.spec.ts` -->
1611

1712
## Connection Import / Export Testing

docs/tracking-plan.md

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,6 @@ Generated on Sun, Jul 27, 2025
121121

122122
- [AI Opt In Modal Shown](#event--AiOptInModalShownEvent)
123123
- [AI Opt In Modal Dismissed](#event--AiOptInModalDismissedEvent)
124-
- [AI Sign In Modal Shown](#event--AiSignInModalShownEvent)
125-
- [AI Sign In Modal Dismissed](#event--AiSignInModalDismissedEvent)
126124
- [AI Generate Query Clicked](#event--AiGenerateQueryClickedEvent)
127125
- [AI Prompt Submitted](#event--AiPromptSubmittedEvent)
128126
- [AI Query Feedback](#event--AiQueryFeedbackEvent)
@@ -1392,18 +1390,6 @@ This event is fired when the AI Opt-In Modal is shown to the user.
13921390

13931391
This event is fired when the AI Opt-In Modal is dismissed by the user.
13941392

1395-
<a name="event--AiSignInModalShownEvent"></a>
1396-
1397-
### AI Sign In Modal Shown
1398-
1399-
This event is fired when the AI Sign-In Modal is shown to the user.
1400-
1401-
<a name="event--AiSignInModalDismissedEvent"></a>
1402-
1403-
### AI Sign In Modal Dismissed
1404-
1405-
This event is fired when the AI Sign-In Modal is dismissed by the user.
1406-
14071393
<a name="event--AiGenerateQueryClickedEvent"></a>
14081394

14091395
### AI Generate Query Clicked

packages/compass-e2e-tests/helpers/selectors.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1382,14 +1382,6 @@ export const ModifySourceBanner = '[data-testid="modify-source-banner"]';
13821382
export const InsightIconButton = '[data-testid="insight-badge-button"]';
13831383
export const InsightPopoverCard = '[data-testid="insight-signal-card"]';
13841384

1385-
// Atlas login
1386-
export const LogInWithAtlasButton = 'button=Log in with Atlas';
1387-
export const LogInWithAtlasModalButton = 'button*=Log in to Atlas';
1388-
export const DisconnectAtlasAccountButton = 'button=Log Out';
1389-
export const AtlasLoginStatus = '[data-testid="atlas-login-status"]';
1390-
export const AtlasLoginErrorToast = '#atlas-sign-in-error';
1391-
export const AgreeAndContinueButton = 'button=Agree and continue';
1392-
13931385
// Proxy settings
13941386
export const ProxyUrl =
13951387
'[data-testid="proxy-settings"] [data-testid="proxy-url"]';

packages/compass-generative-ai/src/components/ai-signin-modal.tsx

Lines changed: 0 additions & 123 deletions
This file was deleted.

packages/compass-generative-ai/src/components/plugin.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import React from 'react';
2-
import AISignInModal from './ai-signin-modal';
32
import AIOptInModal from './ai-optin-modal';
43
import { ConfirmationModalArea } from '@mongodb-js/compass-components';
54

@@ -12,7 +11,6 @@ export const AtlasAiPlugin: React.FunctionComponent<AtlasAiPluginProps> = ({
1211
}) => {
1312
return (
1413
<ConfirmationModalArea>
15-
<AISignInModal></AISignInModal>
1614
<AIOptInModal projectId={projectId}></AIOptInModal>
1715
</ConfirmationModalArea>
1816
);

packages/compass-generative-ai/src/store/atlas-ai-store.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,5 @@
11
import { createStore, applyMiddleware, combineReducers } from 'redux';
22
import thunk from 'redux-thunk';
3-
import signInReducer, {
4-
atlasServiceSignedIn,
5-
atlasServiceSignedOut,
6-
atlasServiceSignInTokenRefreshFailed,
7-
} from './atlas-signin-reducer';
83
import optInReducer from './atlas-optin-reducer';
94
import type { AtlasAuthService } from '@mongodb-js/atlas-service/provider';
105
import type { AtlasAiService } from '../atlas-ai-service';
@@ -21,7 +16,6 @@ export function getStore() {
2116
return store;
2217
}
2318
const reducer = combineReducers({
24-
signIn: signInReducer,
2519
optIn: optInReducer,
2620
});
2721

@@ -33,17 +27,7 @@ export function activatePlugin(
3327
{ cleanup }: ActivateHelpers
3428
) {
3529
store = configureStore(services);
36-
services.atlasAuthService.on('signed-in', () => {
37-
void store.dispatch(atlasServiceSignedIn());
38-
});
3930

40-
services.atlasAuthService.on('signed-out', () => {
41-
void store.dispatch(atlasServiceSignedOut());
42-
});
43-
44-
services.atlasAuthService.on('token-refresh-failed', () => {
45-
void store.dispatch(atlasServiceSignInTokenRefreshFailed());
46-
});
4731
return { store, deactivate: cleanup };
4832
}
4933
export type CompassGenerativeAIExtraArgs = {

0 commit comments

Comments
 (0)