fix

Author: paula-stacho

packages/compass-components/src/components/error-warning-summary.tsx

@@ -77,6 +77,7 @@ const BannerWithSummary: React.FunctionComponent<
     variant: BannerVariant;
     ['data-testid']?: string;
     className?: string;
+    dismissible?: boolean;
   } & (
     | { actionText: string; onAction(): void }
     | { actionText?: never; onAction?: never }
@@ -88,6 +89,7 @@ const BannerWithSummary: React.FunctionComponent<
   actionText,
   variant,
   className,
+  dismissible,
 }) => {
   const _messages = useMemo(() => {
     return !Array.isArray(messages) ? [messages] : messages;
@@ -98,6 +100,7 @@ const BannerWithSummary: React.FunctionComponent<
       data-testid={dataTestId}
       variant={variant}
       className={cx(bannerStyle, className)}
+      dismissible={dismissible}
     >
       <div className={summaryStyles}>
         <Summary messages={_messages}></Summary>

packages/compass-schema/src/components/schema-toolbar/schema-toolbar.tsx

@@ -133,10 +133,14 @@ const SchemaToolbar: React.FunctionComponent<SchemaToolbarProps> = ({
         <ErrorSummary
           data-testid="schema-toolbar-error-message"
           errors={[`${ERROR_WARNING}: ${error.errorMessage}`]}
+          dismissible={true}
         />
       )}
       {error?.errorType === 'TIMEOUT' && (
-        <WarningSummary warnings={[INCREASE_MAX_TIME_MS_HINT_MESSAGE]} />
+        <WarningSummary
+          warnings={[INCREASE_MAX_TIME_MS_HINT_MESSAGE]}
+          dismissible={true}
+        />
       )}
       {error?.errorType === 'HIGH_COMPLEXITY' && (
         <Banner

packages/compass-schema/src/modules/schema-analysis.spec.ts

@@ -7,6 +7,10 @@ import { createNoopLogger } from '@mongodb-js/compass-logging/provider';
 import { isInternalFieldPath } from 'hadron-document';
 
 import { analyzeSchema, calculateSchemaMetadata } from './schema-analysis';
+import {
+  createSandboxFromDefaultPreferences,
+  type PreferencesAccess,
+} from 'compass-preferences-model';
 
 const testDocs = [
   {
@@ -64,8 +68,13 @@ const testDocs = [
 ];
 
 const dummyLogger = createNoopLogger('TEST');
+let preferences: PreferencesAccess;
 
 describe('schema-analysis', function () {
+  beforeEach(async function () {
+    preferences = await createSandboxFromDefaultPreferences();
+  });
+
   afterEach(function () {
     sinon.restore();
   });
@@ -89,7 +98,8 @@ describe('schema-analysis', function () {
         'db.coll',
         {},
         {},
-        dummyLogger
+        dummyLogger,
+        preferences
       );
 
       const expectedSchema = {
@@ -182,7 +192,8 @@ describe('schema-analysis', function () {
         'db.coll',
         {},
         {},
-        dummyLogger
+        dummyLogger,
+        preferences
       );
 
       expect(sampleSpy).to.have.been.calledWith(
@@ -207,7 +218,8 @@ describe('schema-analysis', function () {
         'db.coll',
         {},
         {},
-        dummyLogger
+        dummyLogger,
+        preferences
       );
 
       expect(result).to.equal(undefined);
@@ -235,7 +247,8 @@ describe('schema-analysis', function () {
           'db.coll',
           {},
           {},
-          dummyLogger
+          dummyLogger,
+          preferences
         );
       } catch (err: any) {
         expect(err.message).to.equal('should have been thrown');

packages/compass-schema/src/modules/schema-analysis.ts

@@ -12,7 +12,7 @@ import type {
 } from 'mongodb-schema';
 import type { DataService } from '../stores/store';
 import type { Logger } from '@mongodb-js/compass-logging';
-import { usePreference } from 'compass-preferences-model/provider';
+import type { PreferencesAccess } from 'compass-preferences-model';
 
 // hack for driver 3.6 not promoting error codes and
 // attributes from ejson when promoteValue is false.
@@ -40,7 +40,8 @@ export const analyzeSchema = async (
       }
     | undefined,
   aggregateOptions: AggregateOptions,
-  { log, mongoLogId, debug }: Logger
+  { log, mongoLogId, debug }: Logger,
+  preferences: PreferencesAccess
 ): Promise<SchemaAccessor | undefined> => {
   try {
     log.info(mongoLogId(1001000089), 'Schema', 'Starting schema analysis', {
@@ -59,7 +60,7 @@ export const analyzeSchema = async (
         fallbackReadPreference: 'secondaryPreferred',
       }
     );
-    const enableExportSchema = usePreference('enableExportSchema');
+    const { enableExportSchema } = preferences.getPreferences();
     const schemaParseOptions: SchemaParseOptions = enableExportSchema
       ? {
           signal: abortSignal,

packages/compass-schema/src/stores/schema-analysis-reducer.ts

@@ -304,7 +304,8 @@ export const startAnalysis = (): SchemaThunkAction<
         namespace,
         samplingOptions,
         driverOptions,
-        logger
+        logger,
+        preferences
       );
       if (abortSignal?.aborted) {
         throw new Error(abortSignal?.reason || new Error('Operation aborted'));