fix: delete without assertion

gagik · gagik · commit 5687f2690ba2 · 2025-05-07T08:31:07.000+02:00
diff --git a/packages/compass-e2e-tests/helpers/telemetry.ts b/packages/compass-e2e-tests/helpers/telemetry.ts
@@ -113,7 +113,8 @@ export async function startTelemetryServer(): Promise<Telemetry> {
 
 export function deleteCommonVariedProperties(entry: unknown): void {
   expect(entry).to.have.property('connection_id');
-  expect(entry).to.have.property('device_id');
   delete (entry as { connection_id: unknown }).connection_id;
+
+  // Device ID is not set in all track events so we delete without asserting.
   delete (entry as { device_id: unknown }).device_id;
 }

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,8 @@ export async function startTelemetryServer(): Promise<Telemetry> {`
`113`	`113`
`114`	`114`	`export function deleteCommonVariedProperties(entry: unknown): void {`
`115`	`115`	`expect(entry).to.have.property('connection_id');`
`116`		`- expect(entry).to.have.property('device_id');`
`117`	`116`	`delete (entry as { connection_id: unknown }).connection_id;`
	`117`	`+`
	`118`	`+ // Device ID is not set in all track events so we delete without asserting.`
`118`	`119`	`delete (entry as { device_id: unknown }).device_id;`
`119`	`120`	`}`