PR suggestions

Author: paula-stacho

packages/compass-schema/src/components/schema-toolbar/schema-toolbar.spec.tsx

@@ -66,7 +66,7 @@ describe('SchemaToolbar', function () {
       renderSchemaToolbar({
         analysisState: 'initial',
         error: {
-          errorType: 'GENERAL',
+          errorType: 'general',
           errorMessage: 'test error msg',
         },
       });
@@ -79,7 +79,7 @@ describe('SchemaToolbar', function () {
       renderSchemaToolbar({
         analysisState: 'initial',
         error: {
-          errorType: 'TIMEOUT',
+          errorType: 'timeout',
           errorMessage: 'test error msg',
         },
       });
@@ -95,7 +95,7 @@ describe('SchemaToolbar', function () {
       renderSchemaToolbar({
         analysisState: 'initial',
         error: {
-          errorType: 'HIGH_COMPLEXITY',
+          errorType: 'highComplexity',
           errorMessage: 'test error msg',
         },
       });

packages/compass-schema/src/components/schema-toolbar/schema-toolbar.tsx

@@ -16,6 +16,7 @@ import type { AnalysisState } from '../../constants/analysis-states';
 import { ANALYSIS_STATE_COMPLETE } from '../../constants/analysis-states';
 import { QueryBar } from '@mongodb-js/compass-query-bar';
 import { type SchemaAnalysisError } from '../../stores/schema-analysis-reducer';
+import { DISTINCT_FIELDS_ABORT_THRESHOLD } from '../../modules/schema-analysis';
 
 const schemaToolbarStyles = css({
   display: 'flex',
@@ -131,33 +132,33 @@ const SchemaToolbar: React.FunctionComponent<SchemaToolbarProps> = ({
           </div>
         </div>
       )}
-      {error?.errorType === 'GENERAL' && (
+      {error?.errorType === 'general' && (
         <ErrorSummary
           data-testid="schema-toolbar-error-message"
           errors={[`${ERROR_WARNING}: ${error.errorMessage}`]}
           dismissible={true}
           onClose={onDismissError}
         />
       )}
-      {error?.errorType === 'TIMEOUT' && (
+      {error?.errorType === 'timeout' && (
         <WarningSummary
           data-testid="schema-toolbar-timeout-message"
           warnings={[INCREASE_MAX_TIME_MS_HINT_MESSAGE]}
           dismissible={true}
           onClose={onDismissError}
         />
       )}
-      {error?.errorType === 'HIGH_COMPLEXITY' && (
+      {error?.errorType === 'highComplexity' && (
         <Banner
           variant={BannerVariant.Danger}
           data-testid="schema-toolbar-complexity-abort-message"
           dismissible={true}
           onClose={onDismissError}
         >
-          The analysis was aborted because the number of fields exceeds 1000.
-          Consider breaking up your data into more collections with smaller
-          documents, and using references to consolidate the data you
-          need.&nbsp;
+          The analysis was aborted because the number of fields exceeds{' '}
+          {DISTINCT_FIELDS_ABORT_THRESHOLD}. Consider breaking up your data into
+          more collections with smaller documents, and using references to
+          consolidate the data you need.&nbsp;
           <Link href="https://www.mongodb.com/docs/manual/data-modeling/design-antipatterns/bloated-documents/">
             Learn more
           </Link>

packages/compass-schema/src/modules/schema-analysis.ts

@@ -14,6 +14,8 @@ import type { DataService } from '../stores/store';
 import type { Logger } from '@mongodb-js/compass-logging';
 import type { PreferencesAccess } from 'compass-preferences-model';
 
+export const DISTINCT_FIELDS_ABORT_THRESHOLD = 1000;
+
 // hack for driver 3.6 not promoting error codes and
 // attributes from ejson when promoteValue is false.
 function promoteMongoErrorCode(err?: Error & { code?: unknown }) {
@@ -65,7 +67,7 @@ export const analyzeSchema = async (
       ? {
           signal: abortSignal,
           storedValuesLengthLimit: 100,
-          distinctFieldsAbortThreshold: 1000,
+          distinctFieldsAbortThreshold: DISTINCT_FIELDS_ABORT_THRESHOLD,
         }
       : {
           signal: abortSignal,

packages/compass-schema/src/stores/schema-analysis-reducer.ts

@@ -27,7 +27,7 @@ const ERROR_CODE_MAX_TIME_MS_EXPIRED = 50;
 
 export type SchemaAnalysisError = {
   errorMessage: string;
-  errorType: 'TIMEOUT' | 'HIGH_COMPLEXITY' | 'GENERAL';
+  errorType: 'timeout' | 'highComplexity' | 'general';
 };
 
 export type SchemaAnalysisState = {
@@ -128,11 +128,11 @@ export const schemaAnalysisReducer: Reducer<SchemaAnalysisState, Action> = (
 function getErrorDetails(error: Error): SchemaAnalysisError {
   const errorCode = (error as MongoError).code;
   const errorMessage = error.message || 'Unknown error';
-  let errorType: SchemaAnalysisError['errorType'] = 'GENERAL';
+  let errorType: SchemaAnalysisError['errorType'] = 'general';
   if (errorCode === ERROR_CODE_MAX_TIME_MS_EXPIRED) {
-    errorType = 'TIMEOUT';
+    errorType = 'timeout';
   } else if (error.message.includes('Schema analysis aborted: Fields count')) {
-    errorType = 'HIGH_COMPLEXITY';
+    errorType = 'highComplexity';
   }
 
   return {