INT-727 Implement feature tour

fixed problem with event delegation and clicking slightly off the
target element, removed some redundant code

Author: Kevin Meyer

src/tour/index.js

@@ -30,24 +30,23 @@ var TourView = View.extend({
       that.$featuresLI[that.tourCount].className = '';
 
       if (that.tourCount == 4) {
-        // do last
         that.tourCount = 0;
-        that.$featuresLI[that.tourCount].className = 'selected';        
-        that.$animationGIF.src = that.tourImagesFolder + that.tourImages [that.tourCount];      
       } else {
-        // advance
         that.tourCount++;
-        that.$featuresLI[that.tourCount].className = 'selected';
-        that.$animationGIF.src = that.tourImagesFolder + that.tourImages [that.tourCount];      
       }
+      that.$featuresLI[that.tourCount].className = 'selected';
+      that.$animationGIF.src = that.tourImagesFolder + that.tourImages [that.tourCount];      
     }, 1000 * 7);
   },
 
   showFeature: function(ev) {
-    var nFeature = parseInt(ev.target.getAttribute ('data-n'), 2);
+    var nCLick = ev.target.getAttribute ('data-n');
+    if (nCLick == null) {
+      return false;
+    }
+    var nFeature = parseInt(nCLick, 10);
     this.$featuresLI[this.tourCount].className = '';
     ev.target.className = 'selected';
-    this.$tourRemove.className = 'btn btn-primary';
     this.$animationGIF.src = this.tourImagesFolder + ev.target.id + '.gif';    
     this.tourCount = nFeature;
     clearInterval(this.playAuto);

src/tour/index.less

@@ -23,7 +23,6 @@
 
   width: 80%;
   max-width: 925px;
-  // height: 420px;
   position: absolute;
   background-color: white;
   border-radius: 9px;
@@ -70,7 +69,7 @@
     li.selected {
       color: #24b8eb;
       background-image: url(images/tour/tour-selected.png);
-      background-size: 25px 20px;
+      background-size: 26px 20px;
       background-repeat: no-repeat;
       background-position: 0px 4px;
     }