Remove the charts plugin (#1273)

* Remove the charts plugin

* Fix eslint errors

Author: durran

package.json

@@ -39,7 +39,6 @@
             "node_modules/@mongodb-js/compass-auth-kerberos",
             "node_modules/@mongodb-js/compass-auth-ldap",
             "node_modules/@mongodb-js/compass-auth-x509",
-            "node_modules/@mongodb-js/compass-charts",
             "node_modules/@mongodb-js/compass-crud",
             "node_modules/@mongodb-js/compass-connect",
             "node_modules/@mongodb-js/compass-document-validation",
@@ -58,7 +57,6 @@
           "productName": "MongoDB Compass Community",
           "plugins-directory": ".mongodb/compass-community/plugins",
           "plugins": [
-            "node_modules/@mongodb-js/compass-charts",
             "node_modules/@mongodb-js/compass-connect",
             "node_modules/@mongodb-js/compass-crud",
             "node_modules/@mongodb-js/compass-deployment-awareness",
@@ -141,7 +139,6 @@
     "@mongodb-js/compass-auth-kerberos": "^0.0.2",
     "@mongodb-js/compass-auth-ldap": "^0.0.2",
     "@mongodb-js/compass-auth-x509": "^0.0.3",
-    "@mongodb-js/compass-charts": "^0.5.0",
     "@mongodb-js/compass-connect": "^0.0.7",
     "@mongodb-js/compass-crud": "^0.7.1",
     "@mongodb-js/compass-deployment-awareness": "^5.0.0",

src/app/models/preferences.js

@@ -3,8 +3,6 @@ const storageMixin = require('storage-mixin');
 const _ = require('lodash');
 const format = require('util').format;
 const electronApp = require('electron').remote.app;
-const semver = require('semver');
-const pkg = require('../../../package.json');
 
 const debug = require('debug')('mongodb-compass:models:preferences');
 
@@ -240,13 +238,6 @@ const preferencesProps = {
   }
 };
 
-const prerelease = semver.prerelease(pkg.version);
-if (!prerelease || prerelease[0] !== 'dev') {
-  // COMPASS-1340: Disable chartView for all builds except development,
-  // until it can be moved into a new product coupled to the Charts Server.
-  delete preferencesProps.chartView;
-}
-
 const Preferences = Model.extend(storageMixin, {
   props: preferencesProps,
   extraProperties: 'ignore',
@@ -295,10 +286,6 @@ const Preferences = Model.extend(storageMixin, {
     var res = _.get(this, feature, null);
     // don't allow asking for unknown features to prevent bugs
     if (res === null) {
-      if (feature === 'chartView') {
-        // COMPASS-1340 disable chartView error until moved to its own product...
-        return false;
-      }
       throw new Error(format('Feature %s unknown.', feature));
     }
     return res;

src/internal-plugins/collection/lib/components/index.jsx

@@ -77,8 +77,7 @@ class Collection extends React.Component {
 
   roleFiltered(role) {
     const serverVersion = app.instance.build.version;
-    return (!app.isFeatureEnabled('chartView') && role.name === 'CHARTS') ||
-      (role.minimumServerVersion && !semver.gte(serverVersion, role.minimumServerVersion));
+    return (role.minimumServerVersion && !semver.gte(serverVersion, role.minimumServerVersion));
   }
 
   renderReadonly() {