feat(compass-settings): add atlas login section to compass settings feature preview tab COMPASS-7098 (#4742)

* feat(compass-settings): add atlas login section to compass settings feature preview tab

* chore(atlas-service): ignore network errors on revoke

* chore(mocha-config-compass): setup default preferences for compass-plugin test environment

* chore(atlas-service): disable atlas service when network traffic is disabled

Author: gribnoysup

configs/mocha-config-compass/compass-plugin.js

@@ -7,6 +7,7 @@ module.exports = {
   require: [
     ...reactConfig.require,
     path.resolve(__dirname, 'register', 'electron-renderer-register.js'),
+    path.resolve(__dirname, 'register', 'compass-preferences-register.js'),
   ],
   // electron-mocha config options (ignored when run with just mocha)
   // https://github.com/jprichardson/electron-mocha

configs/mocha-config-compass/register/compass-preferences-register.js

@@ -0,0 +1,18 @@
+module.exports = {
+  mochaHooks: {
+    async beforeAll() {
+      // Only do this setup if we are not in electron environment, electron case
+      // is handled in main-process.js
+      if (typeof process.type !== 'undefined') {
+        return;
+      }
+      // For compass-plugin test preset we want to make sure that the
+      // environment is matching compass environment, including the implicit
+      // preferences used by a lot of packages in the monorepo
+      process.env.COMPASS_TEST_USE_PREFERENCES_SANDBOX =
+        process.env.COMPASS_TEST_USE_PREFERENCES_SANDBOX ?? 'true';
+      // NB: Not adding this as a dep in package.json to avoid circular dependency
+      await require('compass-preferences-model').setupPreferences();
+    },
+  },
+};

package-lock.json

@@ -1 +1 @@
-module.exports = require('@mongodb-js/mocha-config-compass/react');
+module.exports = require('@mongodb-js/mocha-config-compass/compass-plugin');

packages/atlas-service/.mocharc.js

@@ -72,6 +72,7 @@
     "@mongodb-js/compass-utils": "^0.3.3",
     "@mongodb-js/devtools-connect": "^2.4.0",
     "@mongodb-js/oidc-plugin": "^0.3.0",
+    "compass-preferences-model": "^2.11.1",
     "electron": "^23.3.12",
     "keytar": "^7.9.0",
     "node-fetch": "^2.6.7",

packages/atlas-service/package.json

@@ -109,7 +109,9 @@ const AISignInModal: React.FunctionComponent<SignInModalProps> = ({
           </Button>
           <Button
             variant="primaryOutline"
-            onClick={onSignInModalClose}
+            onClick={() => {
+              onSignInModalClose?.();
+            }}
             className={cx(buttonStyles, maybeLaterButtonStyles)}
           >
             Maybe later

packages/atlas-service/src/components/ai-signin-modal.tsx

@@ -4,6 +4,7 @@ import { AtlasService, throwIfNotOk } from './main';
 import { promisify } from 'util';
 import type { EventEmitter } from 'events';
 import { once } from 'events';
+import preferencesAccess from 'compass-preferences-model';
 
 const wait = promisify(setTimeout);
 
@@ -52,6 +53,7 @@ describe('AtlasServiceMain', function () {
 
   const fetch = AtlasService['fetch'];
   const ipcMain = AtlasService['ipcMain'];
+  const createPlugin = AtlasService['createMongoDBOIDCPlugin'];
   const apiBaseUrl = process.env.COMPASS_ATLAS_SERVICE_BASE_URL;
   const issuer = process.env.COMPASS_OIDC_ISSUER;
   const clientId = process.env.COMPASS_CLIENT_ID;
@@ -74,6 +76,7 @@ describe('AtlasServiceMain', function () {
     AtlasService['token'] = null;
     AtlasService['initPromise'] = null;
     AtlasService['oidcPluginSyncedFromLoggerState'] = 'initial';
+    AtlasService['createMongoDBOIDCPlugin'] = createPlugin;
 
     sandbox.resetHistory();
   });
@@ -542,7 +545,8 @@ describe('AtlasServiceMain', function () {
           .stub()
           .rejects(new Error('Could not retrieve valid access token'));
       const createPlugin = () => mockOidcPlugin;
-      const initPromise = AtlasService.init(createPlugin);
+      AtlasService['createMongoDBOIDCPlugin'] = createPlugin;
+      const initPromise = AtlasService.init();
       expect(AtlasService).to.have.property(
         'oidcPluginSyncedFromLoggerState',
         'restoring'
@@ -558,7 +562,8 @@ describe('AtlasServiceMain', function () {
       mockOidcPlugin.mongoClientOptions.authMechanismProperties.REQUEST_TOKEN_CALLBACK =
         sandbox.stub().resolves({ accessToken: 'token' });
       const createPlugin = () => mockOidcPlugin;
-      const initPromise = AtlasService.init(createPlugin);
+      AtlasService['createMongoDBOIDCPlugin'] = createPlugin;
+      const initPromise = AtlasService.init();
       expect(AtlasService).to.have.property(
         'oidcPluginSyncedFromLoggerState',
         'restoring'
@@ -570,4 +575,38 @@ describe('AtlasServiceMain', function () {
       );
     });
   });
+
+  describe('with networkTraffic turned off', function () {
+    const networkTraffic = preferencesAccess.getPreferences().networkTraffic;
+
+    before(async function () {
+      await preferencesAccess.savePreferences({ networkTraffic: false });
+    });
+
+    after(async function () {
+      await preferencesAccess.savePreferences({ networkTraffic });
+    });
+
+    for (const methodName of [
+      'requestOAuthToken',
+      'signIn',
+      'getUserInfo',
+      'introspect',
+      'revoke',
+      'getAggregationFromUserInput',
+      'getQueryFromUserInput',
+    ]) {
+      it(`${methodName} should throw`, async function () {
+        try {
+          await (AtlasService as any)[methodName]({});
+          expect.fail(`Expected ${methodName} to throw`);
+        } catch (err) {
+          expect(err).to.have.property(
+            'message',
+            'Network traffic is not allowed'
+          );
+        }
+      });
+    }
+  });
 });