chore(explain-aggregation): remove feature flag COMPASS-5849 (#3122)

Co-authored-by: Sergey Petushkov <[email protected]>

Author: mabaasit

packages/compass-aggregations/src/components/pipeline-toolbar/pipeline-header/pipeline-actions.spec.tsx

@@ -7,8 +7,6 @@ import type { SinonSpy } from 'sinon';
 
 import { PipelineActions } from './pipeline-actions';
 
-const initialEnableExplain = process.env.COMPASS_ENABLE_AGGREGATION_EXPLAIN;
-
 describe('PipelineActions', function () {
   describe('options visible', function () {
     let onRunAggregationSpy: SinonSpy;
@@ -17,7 +15,6 @@ describe('PipelineActions', function () {
     let onExplainAggregationSpy: SinonSpy;
 
     beforeEach(function () {
-      process.env.COMPASS_ENABLE_AGGREGATION_EXPLAIN = 'true';
       onRunAggregationSpy = spy();
       onToggleOptionsSpy = spy();
       onExportAggregationResultsSpy = spy();
@@ -39,10 +36,6 @@ describe('PipelineActions', function () {
       );
     });
 
-    afterEach(function () {
-      process.env.COMPASS_ENABLE_AGGREGATION_EXPLAIN = initialEnableExplain;
-    });
-
     it('calls onRunAggregation callback on click', function () {
       const button = screen.getByTestId('pipeline-toolbar-run-button');
       expect(button).to.exist;
@@ -123,7 +116,6 @@ describe('PipelineActions', function () {
     let onExplainAggregationSpy: SinonSpy;
 
     beforeEach(function () {
-      process.env.COMPASS_ENABLE_AGGREGATION_EXPLAIN = 'true';
       onRunAggregationSpy = spy();
       onExportAggregationResultsSpy = spy();
       onExplainAggregationSpy = spy();
@@ -145,10 +137,6 @@ describe('PipelineActions', function () {
       );
     });
 
-    afterEach(function () {
-      process.env.COMPASS_ENABLE_AGGREGATION_EXPLAIN = initialEnableExplain;
-    });
-
     it('run action disabled', function () {
       const button = screen.getByTestId('pipeline-toolbar-run-button');
       expect(button.getAttribute('disabled')).to.exist;

packages/compass-aggregations/src/components/pipeline-toolbar/pipeline-header/pipeline-actions.tsx

@@ -51,16 +51,13 @@ export const PipelineActions: React.FunctionComponent<PipelineActionsProps> = ({
   showUpdateViewButton,
   isUpdateViewButtonDisabled,
   isExplainButtonDisabled,
-  showExplainButton: _showExplainButton,
+  showExplainButton,
   onUpdateView,
   onRunAggregation,
   onToggleOptions,
   onExportAggregationResults,
   onExplainAggregation,
 }) => {
-  const showExplainButton =
-    process?.env?.COMPASS_ENABLE_AGGREGATION_EXPLAIN === 'true' &&
-    _showExplainButton;
   return (
     <div className={containerStyles}>
       {showUpdateViewButton && (

packages/compass-aggregations/src/components/pipeline/pipeline.jsx

@@ -298,9 +298,7 @@ class Pipeline extends PureComponent {
         {this.renderModifyingViewSourceError()}
         {this.renderPipelineWorkspace()}
         {this.renderSavePipeline()}
-        {process?.env?.COMPASS_ENABLE_AGGREGATION_EXPLAIN === 'true' && (
-          <PipelineExplain />
-        )}
+        <PipelineExplain />
         <Settings
           isAtlasDeployed={this.props.isAtlasDeployed}
           isExpanded={this.props.settings.isExpanded}

packages/compass-e2e-tests/tests/collection-aggregations-tab.test.ts

@@ -25,10 +25,6 @@ async function waitForAnyText(
     return text !== '';
   });
 }
-const initialAggregationToolbarValue =
-  process.env.COMPASS_SHOW_NEW_AGGREGATION_TOOLBAR;
-const initialAggregationExplainValue =
-  process.env.COMPASS_ENABLE_AGGREGATION_EXPLAIN;
 
 async function goToRunAggregation(browser: CompassBrowser) {
   if (await browser.$(Selectors.AggregationBuilderWorkspace).isDisplayed()) {
@@ -726,9 +722,6 @@ describe('Aggregation Explain', function () {
   let browser: CompassBrowser;
 
   before(async function () {
-    process.env.COMPASS_SHOW_NEW_AGGREGATION_TOOLBAR = 'true';
-    process.env.COMPASS_ENABLE_AGGREGATION_EXPLAIN = 'true';
-
     compass = await beforeTests();
     browser = compass.browser;
   });
@@ -749,10 +742,6 @@ describe('Aggregation Explain', function () {
   });
 
   after(async function () {
-    process.env.COMPASS_SHOW_NEW_AGGREGATION_TOOLBAR =
-      initialAggregationToolbarValue;
-    process.env.COMPASS_ENABLE_AGGREGATION_EXPLAIN =
-      initialAggregationExplainValue;
     await afterTests(compass, this.currentTest);
   });
 

packages/compass/src/index.d.ts

@@ -52,11 +52,6 @@ declare module 'process' {
 
         COMPASS_CLUSTERED_COLLECTIONS?: 'true' | 'false';
 
-        /**
-         * Enable aggregation explain feature
-         */
-        COMPASS_ENABLE_AGGREGATION_EXPLAIN?: 'true' | 'false';
-
         /**
          * Permanent feature flag for debugging.
          */