remove de check and filter out search stages

Author: DarshanaVenkatesh

packages/compass-aggregations/src/components/stage-toolbar/stage-operator-select.tsx

@@ -107,9 +107,7 @@ export const StageOperatorSelect = ({
     [onChange, index]
   );
 
-  const enableAtlasSearchIndexes = usePreference('enableAtlasSearchIndexes');
   const versionIncompatibleCompass =
-    enableAtlasSearchIndexes &&
     !VIEW_PIPELINE_UTILS.isVersionSearchCompatibleForViewsCompass(
       serverVersion
     );
@@ -176,6 +174,7 @@ export default withPreferences(
         isTimeSeries: state.isTimeSeries,
         sourceName: state.sourceName,
         preferencesReadOnly: ownProps.readOnly,
+        enableAtlasSearchIndexes: usePreference('enableAtlasSearchIndexes'),
       });
       return {
         selectedStage: stage.stageOperator,

packages/compass-aggregations/src/utils/stage.ts

@@ -47,12 +47,14 @@ export const filterStageOperators = ({
   isTimeSeries,
   sourceName,
   preferencesReadOnly,
+  enableAtlasSearchIndexes,
 }: {
   serverVersion: string;
   env: ServerEnvironment;
   isTimeSeries: boolean;
   sourceName: string | null;
   preferencesReadOnly: boolean;
+  enableAtlasSearchIndexes: boolean;
 }): FilteredStageOperators => {
   const namespaceType = isTimeSeries
     ? TIME_SERIES
@@ -66,6 +68,7 @@ export const filterStageOperators = ({
     env,
     namespaceType,
     preferencesReadOnly,
+    enableAtlasSearchIndexes,
   });
 
   if (FilteredStagesCache.has(cacheKey)) {
@@ -85,9 +88,14 @@ export const filterStageOperators = ({
             [env, ATLAS]
           : env,
     },
-  }).filter((op) => {
-    return disallowOutputStagesOnCompassReadonly(op, preferencesReadOnly);
-  });
+  })
+    .filter((op) => {
+      return disallowOutputStagesOnCompassReadonly(op, preferencesReadOnly);
+    })
+    .filter((op) => {
+      // if enableAtlasSearchIndexes is false, only allow non search stages
+      return enableAtlasSearchIndexes || !isSearchStage(op.value);
+    });
 
   FilteredStagesCache.set(cacheKey, filteredStages);