with confirmation hook

Author: DarshanaVenkatesh

packages/compass-aggregations/src/components/confirm-update-view-model/confirm-update-view-modal.tsx

@@ -14,7 +14,7 @@ import {
   exportAggregationResults,
   runAggregation,
 } from '../../../modules/aggregation';
-import { openConfirmUpdateModal } from '../../../modules/update-view';
+import { updateView } from '../../../modules/update-view';
 import { explainAggregation } from '../../../modules/explain';
 import {
   getIsPipelineInvalidFromBuilderState,
@@ -189,7 +189,7 @@ const mapState = (state: RootState) => {
 };
 
 const mapDispatch = {
-  onUpdateView: openConfirmUpdateModal,
+  onUpdateView: updateView,
   onRunAggregation: runAggregation,
   onExportAggregationResults: exportAggregationResults,
   onExplainAggregation: explainAggregation,

packages/compass-aggregations/src/components/confirm-update-view-model/index.ts

@@ -19,10 +19,10 @@ import comments from './comments';
 import autoPreview from './auto-preview';
 import id from './id';
 import savedPipeline from './saved-pipeline';
-import updateView from './update-view';
 import settings from './settings';
 import savingPipeline from './saving-pipeline';
 import outResultsFn from './out-results-fn';
+import updateViewError from './update-view';
 import aggregation from './aggregation';
 import countDocuments from './count-documents';
 import isDataLake from './is-datalake';
@@ -77,6 +77,7 @@ const rootReducer = combineReducers({
   editViewName,
   sourceName,
   outResultsFn,
+  updateViewError,
   aggregation,
   workspace,
   countDocuments,
@@ -89,7 +90,6 @@ const rootReducer = combineReducers({
   insights,
   searchIndexes,
   collectionStats,
-  updateView,
 });
 
 export type RootState = ReturnType<typeof rootReducer>;

packages/compass-aggregations/src/components/pipeline-toolbar/pipeline-header/pipeline-actions.tsx

@@ -8,30 +8,15 @@ import {
 import type { PipelineBuilderThunkAction } from '.';
 import { isAction } from '../utils/is-action';
 import type { AnyAction } from 'redux';
+import { showConfirmation } from '@mongodb-js/compass-components';
+import { fetchIndexes } from './search-indexes';
 
-export type UpdateViewState = {
-  isOpen: boolean;
-  updateViewError: null | string;
-};
-
-export const INITIAL_STATE: UpdateViewState = {
-  isOpen: false,
-  updateViewError: null,
-};
-
-// Action for opening model.
-export const OPEN_CONFIRM_UPDATE_MODEL =
-  'aggregations/update-view/OPEN_CONFIRM_UPDATE_MODEL' as const;
-interface OpenConfirmUpdateModel {
-  type: typeof OPEN_CONFIRM_UPDATE_MODEL;
-}
+export type UpdateViewState = null | string;
 
-// Action for closing model.
-export const CLOSE_CONFIRM_UPDATE_MODEL =
-  'aggregations/update-view/CLOSE_CONFIRM_UPDATE_MODEL' as const;
-interface CloseConfirmUpdateModel {
-  type: typeof CLOSE_CONFIRM_UPDATE_MODEL;
-}
+/**
+ * State `null` when there is no error, or string if there's an error.
+ */
+export const INITIAL_STATE: UpdateViewState = null;
 
 // Action for when an error occurs when updating a view.
 export const ERROR_UPDATING_VIEW =
@@ -49,34 +34,15 @@ interface DismissViewUpdateErrorAction {
 }
 
 export type UpdateViewAction =
-  | OpenConfirmUpdateModel
-  | CloseConfirmUpdateModel
   | ErrorUpdatingViewAction
   | DismissViewUpdateErrorAction;
 
 export default function reducer(
   state: UpdateViewState = INITIAL_STATE,
   action: AnyAction
 ): UpdateViewState {
-  if (isAction<OpenConfirmUpdateModel>(action, OPEN_CONFIRM_UPDATE_MODEL)) {
-    return {
-      ...state,
-      isOpen: true,
-    };
-  }
-
-  if (isAction<CloseConfirmUpdateModel>(action, CLOSE_CONFIRM_UPDATE_MODEL)) {
-    return {
-      ...state,
-      isOpen: false,
-    };
-  }
-
   if (isAction<ErrorUpdatingViewAction>(action, ERROR_UPDATING_VIEW)) {
-    return {
-      ...state,
-      updateViewError: action.error,
-    };
+    return action.error;
   }
   if (
     isAction<DismissViewUpdateErrorAction>(action, DISMISS_VIEW_UPDATE_ERROR) ||
@@ -90,23 +56,6 @@ export default function reducer(
   return state;
 }
 
-/**
- * Action creator for opening the confirmation modal.
- *
- * @returns {Object} The action to open the modal.
- */
-export const openConfirmUpdateModal = (): OpenConfirmUpdateModel => ({
-  type: OPEN_CONFIRM_UPDATE_MODEL,
-});
-
-/**
- * Action creator for closing the confirmation modal.
- *
- * @returns {Object} The action to close the modal.
- */
-export const closeConfirmUpdateModal = (): CloseConfirmUpdateModel => ({
-  type: CLOSE_CONFIRM_UPDATE_MODEL,
-});
 /**
  * Action creator for showing the error that occured with updating the view.
  */
@@ -126,6 +75,37 @@ export const dismissViewError = (): DismissViewUpdateErrorAction => ({
   type: DISMISS_VIEW_UPDATE_ERROR,
 });
 
+const isPipelineSearchQueryable = (
+  pipeline: Array<Record<string, any>>
+): boolean => {
+  for (const stage of pipeline) {
+    const stageKey = Object.keys(stage)[0];
+
+    // Check if the stage is $addFields, $set, or $match
+    if (
+      !(
+        stageKey === '$addFields' ||
+        stageKey === '$set' ||
+        stageKey === '$match'
+      )
+    ) {
+      return false; // Not searchable
+    }
+
+    // If the stage is $match, check if uses $expr
+    if (stageKey === '$match') {
+      const matchStage = stage['$match'];
+      const allKeys = Object.keys(matchStage);
+
+      if (!(allKeys.length === 1 && allKeys.includes('$expr'))) {
+        return false; // Not searchable
+      }
+    }
+  }
+
+  return true;
+};
+
 /**
  * Updates a view.
  *
@@ -145,7 +125,6 @@ export const updateView = (): PipelineBuilderThunkAction<Promise<void>> => {
     }
   ) => {
     dispatch(dismissViewError());
-    dispatch(closeConfirmUpdateModal());
 
     const state = getState();
     const ds = state.dataService.dataService;
@@ -161,6 +140,24 @@ export const updateView = (): PipelineBuilderThunkAction<Promise<void>> => {
       getState(),
       pipelineBuilder
     );
+
+    await dispatch(fetchIndexes());
+    if (state.searchIndexes.indexes.length > 0) {
+      const pipelineIsSearchQueryable = isPipelineSearchQueryable(viewPipeline);
+      const confirmed = await showConfirmation({
+        title: `Are you sure you want to update the view?`,
+        description: pipelineIsSearchQueryable
+          ? 'There are search indexes created on this view. Updating the view will result in an index rebuild, which will consume additional resources on your cluster.'
+          : 'This update will make the view incompatible with search indexes and will cause all search indexes to fail. Only views containing $addFields, $set or $match stages with the $expr operator are compatible with search indexes.',
+        buttonText: 'Update',
+        variant: pipelineIsSearchQueryable ? 'primary' : 'danger',
+      });
+
+      if (!confirmed) {
+        return;
+      }
+    }
+
     const options = {
       viewOn: toNS(state.namespace).collection,
       pipeline: viewPipeline,