INT-1650: Fix TypeError: Property 'ssh_tunnel_port' must be of type number (#441)

* INT-1650: Fix TypeError: Property 'ssh_tunnel_port' must be of type number

The form default view is `’’` which is false-y so we were trying to set
an empty string as a number.

* ⬆️ [email protected]

mongodb-js/connection-model#87

- All logic in one place for easier DX and release management
- Refactor `connect()` so if you specify ssh tunnel options, it all
just works.
- New `status` events to enable live updating status bars @rueckstiess
would like to implement.
- This will be an `npm version major` and subsequent major of
data-service.

* ⬆️ [email protected]

* [email protected] uses standard node.js style event names

(cherry picked from commit ac08030)

Author: imlucas

package.json

@@ -121,8 +121,8 @@
     "marked": "^0.3.5",
     "moment": "^2.10.6",
     "mongodb-collection-model": "^0.2.3",
-    "mongodb-connection-model": "^4.3.0",
-    "mongodb-data-service": "^0.3.0",
+    "mongodb-connection-model": "^5.0.0",
+    "mongodb-data-service": "^1.0.0",
     "mongodb-database-model": "^0.1.2",
     "mongodb-explain-plan-model": "^0.2.0",
     "mongodb-extended-json": "^1.6.0",

src/app/connect/connect-form-view.js

@@ -68,9 +68,7 @@ var ConnectFormView = FormView.extend({
     // fill in all default fields
     obj.hostname = obj.hostname.toLowerCase() || 'localhost';
     obj.port = parseInt(obj.port || 27017, 10);
-    if (obj.ssh_tunnel_port) {
-      obj.ssh_tunnel_port = parseInt(obj.ssh_tunnel_port, 10);
-    }
+    obj.ssh_tunnel_port = parseInt(obj.ssh_tunnel_port || 22, 10);
 
     // make a friendly connection name
     // this.makeFriendlyName(obj);

src/app/index.js

@@ -398,8 +398,8 @@ app.extend({
 
       var DataService = require('mongodb-data-service');
       app.dataService = new DataService(state.connection)
-        .on(DataService.Events.Readable, state.onClientReady.bind(state))
-        .on(DataService.Events.Error, state.onFatalError.bind(state, 'create client'));
+        .on('readable', state.onClientReady.bind(state))
+        .on('error', state.onFatalError.bind(state, 'create client'));
 
       app.dataService.connect(function() {
         ApplicationStore.dataService = app.dataService;