Skip to content

Commit 70c6f03

Browse files
committed
COMPASS-2720: Don't enable stitch metrics when disabled
1 parent 868e5d1 commit 70c6f03

File tree

1 file changed

+12
-6
lines changed
  • src/internal-plugins/metrics/lib

1 file changed

+12
-6
lines changed

src/internal-plugins/metrics/lib/setup.js

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ module.exports = function() {
2323
metrics.configure({
2424
stitch: {
2525
appId: 'datawarehouseprod-compass-nqnxw',
26-
enabled: true
26+
enabled: app.preferences.trackUsageStatistics
2727
},
2828
bugsnag: {
2929
apiKey: BUGSNAG_KEY,
@@ -137,18 +137,24 @@ module.exports = function() {
137137
metrics.trackers.get('ga').enabled = enabled;
138138
metrics.trackers.get('intercom').enabled = enabled;
139139
if (enabled && !app.preferences.enableFeedbackPanel) {
140-
document.querySelector('#intercom-container').classList.add('hidden');
140+
const container = document.querySelector('#intercom-container');
141+
if (container) {
142+
container.classList.add('hidden');
143+
}
141144
}
142145
// metrics.trackers.get('mixpanel').enabled = enabled;
143146
});
144147
app.preferences.on('change:enableFeedbackPanel', function(prefs, enabled) {
145148
// enable/disable product feedback
146149
metrics.trackers.get('intercom').panelEnabled = enabled;
147150
if (Window && document.querySelector('#intercom-container')) {
148-
if (enabled) {
149-
document.querySelector('#intercom-container').classList.remove('hidden');
150-
} else {
151-
document.querySelector('#intercom-container').classList.add('hidden');
151+
const container = document.querySelector('#intercom-container');
152+
if (container) {
153+
if (enabled) {
154+
container.classList.remove('hidden');
155+
} else {
156+
container.classList.add('hidden');
157+
}
152158
}
153159
}
154160
});

0 commit comments

Comments
 (0)