Skip to content

Commit 7537e4d

Browse files
committed
fixup: e2e test code mirror selector
1 parent 7348128 commit 7537e4d

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

packages/compass-e2e-tests/tests/collection-schema-tab.test.ts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,8 @@ describe('Collection schema tab', function () {
111111

112112
describe('with the enableExportSchema feature flag enabled', function () {
113113
beforeEach(async function () {
114-
// TODO(COMPASS-8819): remove when defaulted true
114+
// TODO(COMPASS-8819): remove web skip when defaulted true.
115+
skipForWeb(this, "can't toggle features in compass-web");
115116
await browser.setFeature('enableExportSchema', true);
116117
});
117118

@@ -135,13 +136,9 @@ describe('Collection schema tab', function () {
135136
const exportSchemaContent = browser.$(Selectors.ExportSchemaOutput);
136137
await exportSchemaContent.waitForDisplayed();
137138

138-
let text = '';
139-
await browser.waitUntil(async function () {
140-
text = await browser.getCodemirrorEditorText(
141-
Selectors.ExportSchemaOutput
142-
);
143-
return text.includes('$schema:');
144-
});
139+
const text = await browser.getCodemirrorEditorText(
140+
Selectors.ExportSchemaOutput
141+
);
145142
const parsedText = JSON.parse(text);
146143
delete parsedText.$defs;
147144
expect(parsedText).to.deep.equal({

packages/compass-schema/src/components/export-schema-modal.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ const ExportSchemaModal: React.FunctionComponent<{
146146
{exportStatus === 'complete' && (
147147
<KeylineCard className={codeEditorContainerStyles}>
148148
<CodemirrorMultilineEditor
149-
id="export-schema-content"
150149
data-testid="export-schema-content"
151150
language="json"
152151
className={codeStyles}

0 commit comments

Comments
 (0)