fix(crud): make sure that the initial state of the store is set right away instead of through setState calls (#5351)

Author: gribnoysup

packages/compass-crud/src/stores/crud-store.spec.ts

@@ -372,101 +372,6 @@ describe('store', function () {
     });
   });
 
-  describe('#onCollectionChanged', function () {
-    let store: CrudStore;
-
-    beforeEach(function () {
-      const plugin = activateDocumentsPlugin(
-        {
-          isSearchIndexesSupported: true,
-          isReadonly: false,
-          isTimeSeries: false,
-          namespace: 'compass-crud.another',
-        },
-        {
-          dataService,
-          localAppRegistry,
-          globalAppRegistry,
-          instance,
-          preferences,
-          logger: createNoopLoggerAndTelemetry(),
-        },
-        createActivateHelpers()
-      );
-      store = plugin.store;
-      deactivate = () => plugin.deactivate();
-    });
-
-    context('when the collection is not readonly', function () {
-      beforeEach(function () {
-        store.state.table.path = ['test-path'];
-        store.state.table.types = ['test-types'];
-        store.state.table.doc = {};
-        store.state.table.editParams = {};
-      });
-
-      it('resets the state for the new editable collection', async function () {
-        const listener = waitForState(store, (state) => {
-          expect(state.table.path).to.deep.equal([]);
-          expect(state.table.types).to.deep.equal([]);
-          expect(state.table.doc).to.equal(null);
-          expect(state.table.editParams).to.equal(null);
-          expect(state.collection).to.equal('another');
-          expect(state.isEditable).to.equal(true);
-          expect(state.ns).to.equal('compass-crud.another');
-        });
-
-        store.onCollectionChanged('compass-crud.another');
-
-        await listener;
-      });
-    });
-
-    context('when the collection is readonly', function () {
-      beforeEach(function () {
-        const plugin = activateDocumentsPlugin(
-          {
-            isSearchIndexesSupported: true,
-            isReadonly: true,
-            isTimeSeries: false,
-            namespace: 'compass-crud.another',
-          },
-          {
-            dataService,
-            localAppRegistry,
-            globalAppRegistry,
-            instance,
-            preferences,
-            logger: createNoopLoggerAndTelemetry(),
-          },
-          createActivateHelpers()
-        );
-        store = plugin.store;
-        deactivate = () => plugin.deactivate();
-        store.state.table.path = ['test-path'];
-        store.state.table.types = ['test-types'];
-        store.state.table.doc = {};
-        store.state.table.editParams = {};
-      });
-
-      it('resets the state for the new readonly collection', async function () {
-        const listener = waitForState(store, (state) => {
-          expect(state.table.path).to.deep.equal([]);
-          expect(state.table.types).to.deep.equal([]);
-          expect(state.table.doc).to.equal(null);
-          expect(state.table.editParams).to.equal(null);
-          expect(state.collection).to.equal('another');
-          expect(state.isEditable).to.equal(false);
-          expect(state.ns).to.equal('compass-crud.another');
-        });
-
-        store.onCollectionChanged('compass-crud.another');
-
-        await listener;
-      });
-    });
-  });
-
   describe('#onQueryChanged', function () {
     let store: CrudStore;