Skip to content

Commit 77fa5d4

Browse files
authored
Merge branch 'main' into remove-use-toast-use-confirmation-modal-hooks
2 parents 5846362 + 5ef2fb8 commit 77fa5d4

File tree

7 files changed

+38
-17
lines changed

7 files changed

+38
-17
lines changed

.github/workflows/authors-and-third-party-notices.yaml

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: Update Authors and Third Party Notices
33
on:
44
# Once a week or on pushes to main
55
schedule:
6-
- cron: "0 3 * * 0"
6+
- cron: '0 3 * * 0'
77
push:
88
branches:
99
- main
@@ -13,6 +13,9 @@ permissions:
1313

1414
jobs:
1515
update_generated_files:
16+
if: |
17+
github.event_name == 'schedule' ||
18+
!startsWith(github.event.head_commit.message, 'chore: update AUTHORS, THIRD-PARTY-NOTICES, Security Test Summary')
1619
name: Update automatically generated files
1720
runs-on: ubuntu-latest
1821
env:
@@ -32,13 +35,13 @@ jobs:
3235

3336
# this is important so git log can pick up on
3437
# the whole history to generate the list of AUTHORS
35-
fetch-depth: "0"
38+
fetch-depth: '0'
3639
token: ${{ steps.app-token.outputs.token }}
3740

3841
- uses: actions/setup-node@v4
3942
with:
4043
node-version: 20.16.0
41-
cache: "npm"
44+
cache: 'npm'
4245

4346
- name: Install [email protected]
4447
run: |
@@ -71,5 +74,15 @@ jobs:
7174
7275
- name: Commit and push
7376
run: |
74-
git commit --no-allow-empty -m "chore: update AUTHORS, THIRD-PARTY-NOTICES, Security Test Summary" || true
75-
git push
77+
# We can't rely on git not allowing empty commits by default: the
78+
# empty commit check happens before the pre-commit hooks run and if
79+
# there is no diff exists after precommit logic was executed, empty
80+
# commit will still be generated. Instead of that we will allow empty
81+
# commit to happen and will check it directly if it's empty or not
82+
git commit --allow-empty -m "chore: update AUTHORS, THIRD-PARTY-NOTICES, Security Test Summary"
83+
if [ $(git diff-tree --name-only --no-commit-id HEAD | wc -l) -gt 0 ]; then
84+
echo "Files changed, pushing update..."
85+
git push
86+
else
87+
echo "No changes to push"
88+
fi

THIRD-PARTY-NOTICES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
The following third-party software is used by and included in **Mongodb Compass**.
2-
This document was automatically generated on Thu Mar 27 2025.
2+
This document was automatically generated on Fri Mar 28 2025.
33

44
## List of dependencies
55

docs/security-test-summary.md

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ handling and credential revocation upon signout.
1414

1515
<!-- Source File: `packages/atlas-service/src/main.spec.ts` -->
1616

17-
1817
## Connection Import / Export Testing
1918

2019
Compass allows users to export and import connections. Our tests verify that
@@ -23,7 +22,6 @@ that encryption for credentials is correctly applied.
2322

2423
<!-- Source File: `packages/compass-e2e-tests/tests/import-export-connections.test.ts` -->
2524

26-
2725
## In-Use Encryption Testing
2826

2927
MongoDB supports a set of features referred to as "In-Use Encryption".
@@ -38,7 +36,6 @@ and never sent in plaintext.
3836

3937
<!-- Source File: `packages/compass-e2e-tests/tests/in-use-encryption.test.ts` -->
4038

41-
4239
## Enhanced Network Isolation Tests
4340

4441
Compass allows users to specify that the application should not perform any
@@ -49,7 +46,6 @@ We ensure that no such network calls happen when this setting is enabled.
4946

5047
<!-- Source File: `packages/compass-e2e-tests/tests/no-network-traffic.test.ts` -->
5148

52-
5349
## OIDC Authentication End-to-End Tests
5450

5551
In addition to our regular tests for the different authentication mechanisms supported
@@ -62,7 +58,6 @@ what the user has previously specified.
6258

6359
<!-- Source File: `packages/compass-e2e-tests/tests/oidc.test.ts` -->
6460

65-
6661
## Connection String Credential Protection Tests
6762

6863
Compass provides a user- or administrator-configurable setting that prevents the application
@@ -71,7 +66,6 @@ which expose connection information honor this setting.
7166

7267
<!-- Source File: `packages/compass-e2e-tests/tests/protect-connection-strings.test.ts` -->
7368

74-
7569
## Automatic Connection Establishment Tests
7670

7771
Since this application accepts remote host connection information on the command line,
@@ -82,27 +76,23 @@ behavior.
8276

8377
<!-- Source File: `packages/compass/src/main/auto-connect.spec.ts` -->
8478

85-
8679
## Connection Form Password Protection
8780

8881
We verify that database credentials are not displayed to users, unless they
8982
are actively in the process of editing them.
9083

9184
<!-- Source File: `packages/connection-form/src/components/connection-string-input.spec.tsx` -->
9285

93-
9486
## Connection Option Validation Rules
9587

9688
We explicitly verify that the application warns users about connection settings
9789
that may result in security issues, for example potentially insecure TLS or Proxy settings.
9890

9991
<!-- Source File: `packages/connection-form/src/utils/validation.spec.ts` -->
10092

101-
10293
## Secure Credential Storage
10394

10495
We ensure that when sensitive information is persisted, in particular database access credentials,
10596
it is cryptographically protected through an OS keychain encryption integration.
10697

10798
<!-- Source File: `packages/connection-info/src/connection-secrets.spec.ts` -->
108-

docs/tracking-plan.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
> the tracking plan for the specific Compass version you can use the following
77
> URL: `https://github.com/mongodb-js/compass/blob/<compass version>/docs/tracking-plan.md`
88
9-
Generated on Thu, Mar 27, 2025
9+
Generated on Fri, Mar 28, 2025
1010

1111
## Table of Contents
1212

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@
4141
"update-authors": "node scripts/generate-authors.js",
4242
"preupdate-third-party-notices": "npm run -w packages/compass compile",
4343
"update-third-party-notices": "cp packages/compass/THIRD-PARTY-NOTICES.md .",
44+
"postupdate-third-party-notices": "npx prettier-compass THIRD-PARTY-NOTICES.md --write",
4445
"update-tracking-plan": "npx ts-node scripts/generate-tracking-plan.ts > docs/tracking-plan.md",
46+
"postupdate-tracking-plan": "npx prettier-compass docs/tracking-plan.md --write",
4547
"bump-packages": "bump-monorepo-packages",
4648
"publish-packages": "lerna publish from-package --no-verify-access --no-push --no-git-tag-version --yes",
4749
"version": "node ./scripts/align-monorepo-dependencies.js --no-commit",
@@ -50,6 +52,7 @@
5052
"update-evergreen-config": "node .evergreen/template-yml.js",
5153
"postupdate-evergreen-config": "evergreen validate .evergreen.yml",
5254
"update-security-test-summary": "ts-node scripts/generate-security-test-summary.ts > docs/security-test-summary.md",
55+
"postupdate-security-test-summary": "npx prettier-compass docs/security-test-summary.md --write",
5356
"prepare": "husky install",
5457
"snyk-test": "node scripts/snyk-test.js",
5558
"pregenerate-vulnerability-report": "npm run compile -w packages/compass && npm run snyk-test",

packages/compass-e2e-tests/tests/collection-documents-tab.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
TEST_COMPASS_WEB,
1111
skipForWeb,
1212
DEFAULT_CONNECTION_NAME_1,
13+
serverSatisfies,
1314
} from '../helpers/compass';
1415
import type { Compass } from '../helpers/compass';
1516
import * as Selectors from '../helpers/selectors';
@@ -691,6 +692,9 @@ FindIterable<Document> result = collection.find(filter);`);
691692
const REQUIRE_PHONE_VALIDATOR =
692693
'{ $jsonSchema: { bsonType: "object", required: [ "phone" ] } }';
693694
beforeEach(async function () {
695+
if (serverSatisfies('< 5.0.0')) {
696+
return this.skip();
697+
}
694698
await browser.setValidation({
695699
connectionName: DEFAULT_CONNECTION_NAME_1,
696700
database: 'test',

packages/compass-e2e-tests/tests/collection-import.test.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import {
1010
skipForWeb,
1111
TEST_COMPASS_WEB,
1212
DEFAULT_CONNECTION_NAME_1,
13+
serverSatisfies,
1314
} from '../helpers/compass';
1415
import type { Compass } from '../helpers/compass';
1516
import * as Selectors from '../helpers/selectors';
@@ -527,6 +528,11 @@ describe('Collection import', function () {
527528
});
528529

529530
it('with JSON + abort on error checked, it displays a validation error with details', async function () {
531+
// 4.x doesn't provide validation details
532+
if (serverSatisfies('< 5.0.0')) {
533+
this.skip();
534+
}
535+
530536
const jsonPath = path.resolve(
531537
__dirname,
532538
'..',
@@ -578,6 +584,11 @@ describe('Collection import', function () {
578584
});
579585

580586
it('with CSV + abort on error unchecked, it includes the details in a file', async function () {
587+
// 4.x doesn't provide validation details
588+
if (serverSatisfies('< 5.0.0')) {
589+
this.skip();
590+
}
591+
581592
const filename = 'array-documents.csv';
582593
const csvPath = path.resolve(__dirname, '..', 'fixtures', filename);
583594

0 commit comments

Comments
 (0)