fix: pull the chromium version from the binary, not the monorepo when testing the packaged app COMPASS-9421 (#7108)

* pull the electron version from the binary, not the monorepo when testing the packaged app

* just use the chrome version directly

Author: lerouxb

packages/compass-e2e-tests/helpers/compass-web-sandbox.ts

@@ -6,7 +6,7 @@ import Debug from 'debug';
 import {
   COMPASS_WEB_SANDBOX_RUNNER_PATH,
   COMPASS_WEB_WDIO_USER_DATA_PATH,
-  ELECTRON_CHROMIUM_VERSION,
+  MONOREPO_ELECTRON_CHROMIUM_VERSION,
   ELECTRON_PATH,
 } from './test-runner-paths';
 import type { ConnectionInfo } from '@mongodb-js/connection-info';
@@ -86,7 +86,7 @@ export async function spawnCompassWebSandboxAndSignInToAtlas(
   const electronProxyRemote = await remote({
     capabilities: {
       browserName: 'chromium',
-      browserVersion: ELECTRON_CHROMIUM_VERSION,
+      browserVersion: MONOREPO_ELECTRON_CHROMIUM_VERSION,
       'goog:chromeOptions': {
         binary: ELECTRON_PATH,
         args: [

packages/compass-e2e-tests/helpers/compass.ts

@@ -32,7 +32,7 @@ import {
   isTestingAtlasCloudExternal,
 } from './test-runner-context';
 import {
-  ELECTRON_CHROMIUM_VERSION,
+  MONOREPO_ELECTRON_CHROMIUM_VERSION,
   LOG_PATH,
   LOG_COVERAGE_PATH,
   COMPASS_DESKTOP_PATH,
@@ -473,6 +473,11 @@ function execFileIgnoreError(
   });
 }
 
+async function getChromiumVersionFromBinary(path: string) {
+  const { stdout } = await execFileIgnoreError(path, ['--versions'], {});
+  return JSON.parse(stdout).chrome;
+}
+
 export async function runCompassOnce(args: string[], timeout = 30_000) {
   const { binary } = await getCompassExecutionParameters();
   debug('spawning compass...', {
@@ -654,7 +659,9 @@ async function startCompassElectron(
     automationProtocol: 'webdriver' as const,
     capabilities: {
       browserName: 'chromium',
-      browserVersion: ELECTRON_CHROMIUM_VERSION,
+      browserVersion: testPackagedApp
+        ? await getChromiumVersionFromBinary(binary)
+        : MONOREPO_ELECTRON_CHROMIUM_VERSION,
       // https://chromedriver.chromium.org/capabilities#h.p_ID_106
       'goog:chromeOptions': {
         binary: maybeWrappedBinary,

packages/compass-e2e-tests/helpers/test-runner-paths.ts

@@ -33,8 +33,10 @@ export const LOG_COVERAGE_PATH = path.join(LOG_PATH, 'coverage');
 export const COVERAGE_PATH = (process.env.COVERAGE = MONOREPO_ROOT_PATH);
 
 export const ELECTRON_PATH = electronPath;
-export const ELECTRON_VERSION = electronPackageJson.version;
-export const ELECTRON_CHROMIUM_VERSION = electronToChromium(ELECTRON_VERSION);
+export const MONOREPO_ELECTRON_VERSION = electronPackageJson.version;
+export const MONOREPO_ELECTRON_CHROMIUM_VERSION = electronToChromium(
+  MONOREPO_ELECTRON_VERSION
+);
 
 export const COMPASS_WEB_SANDBOX_RUNNER_PATH = path.resolve(
   path.dirname(require.resolve('@mongodb-js/compass-web/package.json')),

packages/compass-preferences-model/src/preferences-schema.tsx

@@ -134,6 +134,7 @@ export type CliOnlyPreferences = {
   importConnections?: string;
   passphrase?: string;
   version?: boolean;
+  versions?: boolean;
   help?: boolean;
   showExampleConfig?: boolean;
   trustedConnectionString?: boolean;
@@ -1070,6 +1071,16 @@ const cliOnlyPreferencesProps: Required<{
     validator: z.boolean().optional(),
     type: 'boolean',
   },
+  versions: {
+    ui: false,
+    cli: true,
+    global: false,
+    description: {
+      short: 'Show Node, Electron, Chromium Versions',
+    },
+    validator: z.boolean().optional(),
+    type: 'boolean',
+  },
   showExampleConfig: {
     ui: false,
     cli: true,

packages/compass/src/main/index.ts

@@ -57,6 +57,10 @@ async function main(): Promise<void> {
     process.stdout.write(`${app.getName()} ${app.getVersion()}\n`);
     return app.exit(0);
   }
+  if (preferences.versions) {
+    process.stdout.write(`${JSON.stringify(process.versions)}\n`);
+    return app.exit(0);
+  }
 
   if (preferences.help) {
     process.stdout.write(getHelpText());