Skip to content

Commit 78f1d5f

Browse files
committed
undo webpack changes
1 parent 220cab3 commit 78f1d5f

File tree

2 files changed

+0
-30
lines changed

2 files changed

+0
-30
lines changed

configs/webpack-config-compass/.depcheckrc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,3 @@ ignores:
1818
- 'mongodb-compass'
1919
# used as a resolve alias
2020
- 'jose'
21-
- 'react'

configs/webpack-config-compass/src/index.ts

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -111,14 +111,6 @@ const sharedResolveOptions = (
111111
// Some lg test helpers that are getting bundled due to re-exporting from
112112
// the actual component packages, never needed in the webpack bundles
113113
'@lg-tools/test-harnesses': false,
114-
115-
// The react/jsx-runtime can fail the import when imported from an esm
116-
// module because React 17 doesn't have ./jsx-runtime specified in the
117-
// package.json `exports` field. This issue will go away if we can update
118-
// to React 18, but for the time being we will just resolve react to
119-
// actual files ourselves to work around that
120-
'react/jsx-runtime': require.resolve('react/jsx-runtime'),
121-
react: require.resolve('react'),
122114
},
123115
};
124116
};
@@ -155,17 +147,6 @@ export function createElectronMainConfig(
155147
sharedObjectLoader(opts),
156148
sourceLoader(opts),
157149
],
158-
parser: {
159-
javascript: {
160-
// Webpack compile time check for imports matching exports is too strict
161-
// in cases where the code expects some name export to be optional
162-
// (webpack will break the build if it fails to statically see the
163-
// matching export) this is why we switch the check to just warn. If
164-
// this ever hides a real case where a missing import is being used, it
165-
// will definitely break in runtime anyway
166-
importExportsPresence: 'warn' as const,
167-
},
168-
},
169150
},
170151
node: false as const,
171152
externals: toCommonJsExternal(sharedExternals),
@@ -237,11 +218,6 @@ export function createElectronRendererConfig(
237218
sharedObjectLoader(opts),
238219
sourceLoader(opts),
239220
],
240-
parser: {
241-
javascript: {
242-
importExportsPresence: 'warn' as const,
243-
},
244-
},
245221
},
246222
plugins: [
247223
...entriesToHtml(entries),
@@ -362,11 +338,6 @@ export function createWebConfig(args: Partial<ConfigArgs>): WebpackConfig {
362338
assetsLoader(opts),
363339
sourceLoader(opts),
364340
],
365-
parser: {
366-
javascript: {
367-
importExportsPresence: 'warn' as const,
368-
},
369-
},
370341
},
371342
// This follows current Compass plugin behavior and is here more or less to
372343
// keep compat for the external plugin users

0 commit comments

Comments
 (0)