chore(eslint-config): allow polyfilled nodejs built-ins; temporarily disable new failing rules

Author: gribnoysup

configs/eslint-config-compass/index.js

@@ -15,6 +15,19 @@ const extraTsRules = {
     'error',
     { fixMixedExportsWithInlineTypeSpecifier: false },
   ],
+
+  // TODO: turn those back on
+  '@typescript-eslint/prefer-promise-reject-errors': 'off',
+  '@typescript-eslint/no-explicit-any': 'off',
+  '@typescript-eslint/no-base-to-string': 'off',
+  '@typescript-eslint/no-require-imports': 'off',
+  '@typescript-eslint/no-unsafe-declaration-merging': 'off',
+  '@typescript-eslint/unbound-method': 'off',
+  '@typescript-eslint/no-redundant-type-constituents': 'off',
+  '@typescript-eslint/no-duplicate-type-constituents': 'off',
+  '@typescript-eslint/only-throw-error': 'off',
+  '@typescript-eslint/no-unsafe-enum-comparison': 'off',
+  '@typescript-eslint/no-misused-promises': 'off',
 };
 
 const tsRules = {
@@ -57,6 +70,12 @@ const commonTestOverrides = {
       ],
     },
   ],
+  // Due do chai triggering these rules erroneously in a lot of cases
+  'no-unused-expressions': 'off',
+  '@typescript-eslint/no-unused-expressions': 'off',
+
+  // TODO: turn these back on
+  'mocha/consistent-spacing-between-blocks': 'off',
 };
 
 const testJsOverrides = {

configs/eslint-config-compass/plugin.js

@@ -10,6 +10,9 @@ function restrictedProviderImport(servicePkg) {
   };
 }
 
+// node built-ins with meaningful polyfills in web environment
+const allowedNodeJSBuiltinModules = ['stream', 'events', 'crypto'];
+
 module.exports = {
   ...baseConfig,
   rules: {
@@ -25,14 +28,25 @@ module.exports = {
           restrictedProviderImport('@mongodb-js/my-queries-storage'),
           restrictedProviderImport('@mongodb-js/atlas-service'),
           restrictedProviderImport('compass-preferences-model'),
-          ...require('module').builtinModules.map((name) => {
-            return {
-              name,
-              message:
-                'Using Node.js built-in modules in plugins is not allowed.',
-              allowTypeImports: true,
-            };
-          }),
+          ...require('module')
+            .builtinModules.filter((module) => {
+              return (
+                !module.startsWith('_') &&
+                !allowedNodeJSBuiltinModules.includes(module)
+              );
+            })
+            .flatMap((name) => {
+              const config = {
+                message:
+                  'Using Node.js built-in modules in plugins is not allowed.',
+                allowTypeImports: true,
+              };
+
+              return [
+                { name, ...config },
+                { name: `node:${name}`, ...config },
+              ];
+            }),
           ...['electron', '@electron/remote'].map((name) => {
             return {
               name,