Wait for update server to close

Author: kraenhansen

packages/compass-smoke-tests/src/tests/auto-update-from.ts

@@ -1,12 +1,13 @@
 import assert from 'node:assert/strict';
-import fs from 'node:fs';
+
 import createDebug from 'debug';
+
 import { type SmokeTestsContext } from '../context';
 import { getInstaller } from '../installers';
 import { createSandbox } from '../directories';
 import { getTestSubject } from '../test-subject';
 import { executeAsync } from '../execute';
-import { startAutoUpdateServer } from './update-server';
+import { startAutoUpdateServer, stopAutoUpdateServer } from './update-server';
 
 const debug = createDebug('compass:smoketests:auto-update-from');
 
@@ -66,7 +67,7 @@ export async function testAutoUpdateFrom(context: SmokeTestsContext) {
       );
     } finally {
       debug('Stopping auto-update server');
-      server.close();
+      await stopAutoUpdateServer(server);
       delete process.env.UPDATE_CHECKER_ALLOW_DOWNGRADES;
     }
   } finally {

packages/compass-smoke-tests/src/tests/auto-update-to.ts

@@ -7,7 +7,7 @@ import { createSandbox } from '../directories';
 import { getTestSubjectDetails } from '../test-subject';
 import { executeAsync } from '../execute';
 import { getLatestRelease, getLatestReleaseKindByKind } from '../releases';
-import { startAutoUpdateServer } from './update-server';
+import { startAutoUpdateServer, stopAutoUpdateServer } from './update-server';
 
 const debug = createDebug('compass:smoketests:auto-update-to');
 
@@ -100,7 +100,7 @@ export async function testAutoUpdateTo(context: SmokeTestsContext) {
       );
     } finally {
       debug('Stopping auto-update server');
-      server.close();
+      await stopAutoUpdateServer(server);
       delete process.env.DEV_RELEASE;
       delete process.env.PUBLISHED_RELEASES;
       delete process.env.UPDATE_CHECKER_ALLOW_DOWNGRADES;

packages/compass-smoke-tests/src/tests/update-server.ts

@@ -1,4 +1,7 @@
 import { once } from 'node:events';
+import type http from 'node:http';
+import { promisify } from 'node:util';
+
 import createDebug from 'debug';
 
 const debug = createDebug('compass:smoketests:update-server');
@@ -20,3 +23,7 @@ export async function startAutoUpdateServer() {
 
   return httpServer;
 }
+
+export async function stopAutoUpdateServer(server: http.Server) {
+  await promisify(server.close.bind(server))();
+}