Skip to content

Commit 8141ca5

Browse files
committed
missed a few
1 parent 22bc605 commit 8141ca5

File tree

5 files changed

+43
-37
lines changed

5 files changed

+43
-37
lines changed

packages/compass-e2e-tests/tests/collection-bulk-delete.test.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,13 @@ describe('Bulk Delete', function () {
7070
).to.equal('{ i: 5 }');
7171

7272
// Check that it will update the expected number of documents
73-
expect(browser.$(Selectors.BulkDeleteModalTitle).getText()).to.equal(
73+
expect(await browser.$(Selectors.BulkDeleteModalTitle).getText()).to.equal(
7474
'Delete 1 document'
7575
);
7676

77-
expect(browser.$(Selectors.BulkDeleteModalDeleteButton).getText()).to.equal(
78-
'Delete 1 document'
79-
);
77+
expect(
78+
await browser.$(Selectors.BulkDeleteModalDeleteButton).getText()
79+
).to.equal('Delete 1 document');
8080

8181
// Press delete
8282
await browser.clickVisible(Selectors.BulkDeleteModalDeleteButton);
@@ -130,13 +130,13 @@ describe('Bulk Delete', function () {
130130
await browser.$(Selectors.BulkDeleteModal).waitForDisplayed();
131131

132132
// Check that it will update the expected number of documents
133-
expect(browser.$(Selectors.BulkDeleteModalTitle).getText()).to.equal(
133+
expect(await browser.$(Selectors.BulkDeleteModalTitle).getText()).to.equal(
134134
'Delete 1 document'
135135
);
136136

137-
expect(browser.$(Selectors.BulkDeleteModalDeleteButton).getText()).to.equal(
138-
'Delete 1 document'
139-
);
137+
expect(
138+
await browser.$(Selectors.BulkDeleteModalDeleteButton).getText()
139+
).to.equal('Delete 1 document');
140140

141141
// Press delete
142142
await browser.clickVisible(Selectors.BulkDeleteModalDeleteButton);

packages/compass-e2e-tests/tests/collection-bulk-update.test.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -67,17 +67,17 @@ describe('Bulk Update', () => {
6767
});
6868

6969
// Make sure the query is shown in the modal.
70-
expect(browser.$(Selectors.BulkUpdateReadonlyFilter).getText()).to.equal(
71-
'{ i: 5 }'
72-
);
70+
expect(
71+
await browser.$(Selectors.BulkUpdateReadonlyFilter).getText()
72+
).to.equal('{ i: 5 }');
7373

7474
// Check that it will update the expected number of documents
75-
expect(browser.$(Selectors.BulkUpdateTitle).getText()).to.equal(
76-
'Update 1 document'
77-
);
78-
expect(browser.$(Selectors.BulkUpdateUpdateButton).getText()).to.equal(
75+
expect(await browser.$(Selectors.BulkUpdateTitle).getText()).to.equal(
7976
'Update 1 document'
8077
);
78+
expect(
79+
await browser.$(Selectors.BulkUpdateUpdateButton).getText()
80+
).to.equal('Update 1 document');
8181

8282
// Check that the modal starts with the default update text
8383
expect(
@@ -217,9 +217,9 @@ describe('Bulk Update', () => {
217217
await browser.$(Selectors.BulkUpdateModal).waitForDisplayed();
218218

219219
// Make sure the query is shown in the modal.
220-
expect(browser.$(Selectors.BulkUpdateReadonlyFilter).getText()).to.match(
221-
/{\s+i:\s+{\s+\$gt:\s+5\s+}\s+}/
222-
);
220+
expect(
221+
await browser.$(Selectors.BulkUpdateReadonlyFilter).getText()
222+
).to.match(/{\s+i:\s+{\s+\$gt:\s+5\s+}\s+}/);
223223

224224
// Check that the modal starts with the expected update text
225225
expect(

packages/compass-e2e-tests/tests/collection-import.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,8 +304,10 @@ describe('Collection import', function () {
304304

305305
// confirm
306306
// this selector is very brittle, so just make sure it works
307-
expect(browser.$(Selectors.InsertConfirm).isDisplayed()).to.be.true;
308-
expect(browser.$(Selectors.InsertConfirm).getText()).to.equal('Insert');
307+
expect(await browser.$(Selectors.InsertConfirm).isDisplayed()).to.be.true;
308+
expect(await browser.$(Selectors.InsertConfirm).getText()).to.equal(
309+
'Insert'
310+
);
309311
await browser.$(Selectors.InsertConfirm).waitForEnabled();
310312
await browser.clickVisible(Selectors.InsertConfirm);
311313

packages/compass-e2e-tests/tests/connection-form.test.ts

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ describe('Connection form', function () {
104104

105105
delete expectedState.connectionString;
106106
await browser.setConnectFormState(expectedState);
107-
expect(browser.$(Selectors.ConnectionFormStringInput).getValue()).to.equal(
108-
connectionString
109-
);
107+
expect(
108+
await browser.$(Selectors.ConnectionFormStringInput).getValue()
109+
).to.equal(connectionString);
110110
});
111111

112112
it('parses and formats a URI for multiple hosts', async function () {
@@ -140,9 +140,9 @@ describe('Connection form', function () {
140140

141141
delete expectedState.connectionString;
142142
await browser.setConnectFormState(expectedState);
143-
expect(browser.$(Selectors.ConnectionFormStringInput).getValue()).to.equal(
144-
connectionString
145-
);
143+
expect(
144+
await browser.$(Selectors.ConnectionFormStringInput).getValue()
145+
).to.equal(connectionString);
146146
});
147147

148148
it('parses and formats a URI for mongodb+srv scheme', async function () {
@@ -176,9 +176,9 @@ describe('Connection form', function () {
176176

177177
delete expectedState.connectionString;
178178
await browser.setConnectFormState(expectedState);
179-
expect(browser.$(Selectors.ConnectionFormStringInput).getValue()).to.equal(
180-
connectionString
181-
);
179+
expect(
180+
await browser.$(Selectors.ConnectionFormStringInput).getValue()
181+
).to.equal(connectionString);
182182
});
183183

184184
it('parses and formats a URI for username/password authentication', async function () {
@@ -310,9 +310,9 @@ describe('Connection form', function () {
310310

311311
delete expectedState.connectionString;
312312
await browser.setConnectFormState(expectedState);
313-
expect(browser.$(Selectors.ConnectionFormStringInput).getValue()).to.equal(
314-
connectionString
315-
);
313+
expect(
314+
await browser.$(Selectors.ConnectionFormStringInput).getValue()
315+
).to.equal(connectionString);
316316
});
317317

318318
it('parses and formats a URI for LDAP authentication', async function () {
@@ -477,9 +477,9 @@ describe('Connection form', function () {
477477

478478
delete expectedState.connectionString;
479479
await browser.setConnectFormState(expectedState);
480-
expect(browser.$(Selectors.ConnectionFormStringInput).getValue()).to.equal(
481-
connectionString
482-
);
480+
expect(
481+
await browser.$(Selectors.ConnectionFormStringInput).getValue()
482+
).to.equal(connectionString);
483483
});
484484

485485
it('does not update the URI for SSH tunnel with password authentication', async function () {

packages/compass-e2e-tests/tests/show-kerberos-password-field.test.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@ describe('showKerberosPasswordField', function () {
5252
authMethod: 'GSSAPI',
5353
};
5454
await browser.setConnectFormState(state);
55-
expect(browser.$(Selectors.ConnectionFormStringInput).getValue()).to.equal(
55+
expect(
56+
await browser.$(Selectors.ConnectionFormStringInput).getValue()
57+
).to.equal(
5658
'mongodb://localhost:27017/?authMechanism=GSSAPI&authSource=%24external'
5759
);
5860

@@ -71,7 +73,9 @@ describe('showKerberosPasswordField', function () {
7173
authMethod: 'GSSAPI',
7274
};
7375
await browser.setConnectFormState(state);
74-
expect(browser.$(Selectors.ConnectionFormStringInput).getValue()).to.equal(
76+
expect(
77+
await browser.$(Selectors.ConnectionFormStringInput).getValue()
78+
).to.equal(
7579
'mongodb://localhost:27017/?authMechanism=GSSAPI&authSource=%24external'
7680
);
7781

0 commit comments

Comments
 (0)