Skip to content

Commit 83f5c04

Browse files
committed
chore: move diagramming dependency to compass-components
1 parent 9b7ff5b commit 83f5c04

File tree

12 files changed

+247
-22
lines changed

12 files changed

+247
-22
lines changed

package-lock.json

Lines changed: 212 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/compass-components/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
"@leafygreen-ui/tooltip": "^13.0.13",
7979
"@leafygreen-ui/typography": "^20.0.2",
8080
"@mongodb-js/compass-context-menu": "^0.2.5",
81+
"@mongodb-js/diagramming": "^1.3.3",
8182
"@react-aria/interactions": "^3.9.1",
8283
"@react-aria/utils": "^3.13.1",
8384
"@react-aria/visually-hidden": "^3.3.1",
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
export {
2+
Diagram,
3+
DiagramProvider,
4+
applyLayout,
5+
getNodesBounds,
6+
getViewportForBounds,
7+
useDiagram,
8+
} from '@mongodb-js/diagramming';
9+
export type {
10+
EdgeProps,
11+
DiagramInstance,
12+
NodeProps,
13+
} from '@mongodb-js/diagramming';

packages/compass-components/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
export * from './components/diagramming';
12
export * from './components/leafygreen';
23

34
export {

packages/compass-data-modeling/src/components/data-modeling.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import DiagramEditor from './diagram-editor';
44
import SavedDiagramsList from './saved-diagrams-list';
55
import NewDiagramFormModal from './new-diagram-form';
66
import type { DataModelingState } from '../store/reducer';
7-
import { DiagramProvider } from '@mongodb-js/diagramming';
7+
import { DiagramProvider } from '@mongodb-js/compass-components';
88
import DiagramEditorSidePanel from './drawer/diagram-editor-side-panel';
99

1010
type DataModelingProps = {

packages/compass-data-modeling/src/components/diagram-editor.spec.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ import type {
1111
Edit,
1212
MongoDBDataModelDescription,
1313
} from '../services/data-model-storage';
14-
import diagramming from '@mongodb-js/diagramming';
14+
import compassComponents from '@mongodb-js/compass-components';
1515
import sinon from 'sinon';
16-
import { DiagramProvider } from '@mongodb-js/diagramming';
16+
import { DiagramProvider } from '@mongodb-js/compass-components';
1717
import { DataModelingWorkspaceTab } from '..';
1818
import { openDiagram } from '../store/diagram';
1919

@@ -157,9 +157,9 @@ describe('DiagramEditor', function () {
157157

158158
before(function () {
159159
// We need to tub the Diagram import because it has problems with ESM/CJS interop
160-
sinon.stub(diagramming, 'Diagram').callsFake(mockDiagramming.Diagram);
160+
sinon.stub(compassComponents, 'Diagram').callsFake(mockDiagramming.Diagram);
161161
sinon
162-
.stub(diagramming, 'applyLayout')
162+
.stub(compassComponents, 'applyLayout')
163163
.callsFake(mockDiagramming.applyLayout as any);
164164
});
165165

packages/compass-data-modeling/src/components/diagram-editor.tsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,18 @@ import {
1919
import {
2020
Banner,
2121
CancelLoader,
22+
Diagram,
2223
WorkspaceContainer,
2324
css,
2425
spacing,
2526
Button,
2627
useDarkMode,
28+
useDiagram,
2729
useDrawerActions,
2830
rafraf,
2931
} from '@mongodb-js/compass-components';
3032
import { cancelAnalysis, retryAnalysis } from '../store/analysis-process';
31-
import {
32-
Diagram,
33-
type NodeProps,
34-
type EdgeProps,
35-
useDiagram,
36-
} from '@mongodb-js/diagramming';
33+
import type { NodeProps, EdgeProps } from '@mongodb-js/compass-components';
3734
import type { StaticModel } from '../services/data-model-storage';
3835
import DiagramEditorToolbar from './diagram-editor-toolbar';
3936
import ExportDiagramModal from './export-diagram-modal';

packages/compass-data-modeling/src/components/export-diagram-modal.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import React from 'react';
22
import {
33
Button,
4-
css,
54
Icon,
65
Label,
76
Modal,
@@ -13,7 +12,10 @@ import {
1312
spacing,
1413
SpinLoader,
1514
PngIcon,
15+
css,
16+
useDiagram,
1617
} from '@mongodb-js/compass-components';
18+
import type { DiagramInstance } from '@mongodb-js/compass-components';
1719
import type { ExportDiagramFormat } from '../store/export-diagram';
1820
import {
1921
closeExportModal,
@@ -22,8 +24,6 @@ import {
2224
} from '../store/export-diagram';
2325
import { connect } from 'react-redux';
2426
import type { DataModelingState } from '../store/reducer';
25-
import { useDiagram } from '@mongodb-js/diagramming';
26-
import type { DiagramInstance } from '@mongodb-js/diagramming';
2727

2828
const modelBodyStyles = css({
2929
paddingTop: spacing[600],

packages/compass-data-modeling/src/services/export-diagram.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
import React from 'react';
22
import {
3-
getNodesBounds,
4-
getViewportForBounds,
53
DiagramProvider,
64
Diagram,
7-
} from '@mongodb-js/diagramming';
8-
import type { DiagramInstance } from '@mongodb-js/diagramming';
5+
getNodesBounds,
6+
getViewportForBounds,
7+
rafraf,
8+
spacing,
9+
} from '@mongodb-js/compass-components';
10+
import type { DiagramInstance } from '@mongodb-js/compass-components';
911
import type { StaticModel } from './data-model-storage';
1012
import ReactDOM from 'react-dom';
1113
import { toPng } from 'html-to-image';
12-
import { rafraf, spacing } from '@mongodb-js/compass-components';
1314
import { raceWithAbort } from '@mongodb-js/compass-utils';
1415

1516
function moveSvgDefsToViewportElement(

packages/compass-data-modeling/src/store/analysis-process.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { getCurrentDiagramFromState } from './diagram';
66
import type { Document } from 'bson';
77
import type { AggregationCursor } from 'mongodb';
88
import type { Relationship } from '../services/data-model-storage';
9-
import { applyLayout } from '@mongodb-js/diagramming';
9+
import { applyLayout } from '@mongodb-js/compass-components';
1010
import { collectionToDiagramNode } from '../utils/nodes-and-edges';
1111

1212
export type AnalysisProcessState = {

0 commit comments

Comments
 (0)