feat(compass-aggregations): remove focus mode feature flag, always show COMPASS-6474 (#4152)

Author: Anemy

packages/compass-aggregations/src/components/stage-toolbar/index.tsx

@@ -16,7 +16,6 @@ import ToggleStage from './toggle-stage';
 import StageCollapser from './stage-collapser';
 import StageOperatorSelect from './stage-operator-select';
 import { hasSyntaxError } from '../../utils/stage';
-import { usePreference } from 'compass-preferences-model';
 import { enableFocusMode } from '../../modules/focus-mode';
 import OptionMenu from './option-menu';
 
@@ -110,7 +109,6 @@ export function StageToolbar({
   editorRef,
 }: StageToolbarProps) {
   const darkMode = useDarkMode();
-  const showFocusMode = usePreference('showFocusMode', React);
 
   return (
     <div
@@ -135,16 +133,14 @@ export function StageToolbar({
         {isDisabled ? DISABLED_TEXT : isCollapsed ? COLLAPSED_TEXT : null}
       </div>
       <div className={rightStyles}>
-        {showFocusMode && (
-          <IconButton
-            onClick={onOpenFocusMode}
-            aria-label="Open stage in focus mode"
-            data-testid="focus-mode-button"
-            data-guide-cue-ref="focus-mode-button"
-          >
-            <Icon glyph="FullScreenEnter" size="small"></Icon>
-          </IconButton>
-        )}
+        <IconButton
+          onClick={onOpenFocusMode}
+          aria-label="Open stage in focus mode"
+          data-testid="focus-mode-button"
+          data-guide-cue-ref="focus-mode-button"
+        >
+          <Icon glyph="FullScreenEnter" size="small"></Icon>
+        </IconButton>
         <OptionMenu index={index} />
       </div>
     </div>

packages/compass-aggregations/src/components/stage.tsx

@@ -11,7 +11,6 @@ import {
   GuideCue,
 } from '@mongodb-js/compass-components';
 import { type AceEditor } from '@mongodb-js/compass-editor';
-import { usePreference } from 'compass-preferences-model';
 
 import { useSortable } from '@dnd-kit/sortable';
 import { CSS as cssDndKit } from '@dnd-kit/utilities';
@@ -154,15 +153,12 @@ const useFocusModeGuideCue = (stageIndex: number) => {
   const [setGuideCueIntersectingRef, isIntersecting] = useInView({
     threshold: 0.5,
   });
-  const showFocusMode = usePreference('showFocusMode', React);
 
   useEffect(() => {
     if (!hasSeenFocusModeGuideCue()) {
-      setIsGuideCueVisible(
-        Boolean(stageIndex === 0 && showFocusMode && isIntersecting)
-      );
+      setIsGuideCueVisible(Boolean(stageIndex === 0 && isIntersecting));
     }
-  }, [setIsGuideCueVisible, showFocusMode, stageIndex, isIntersecting]);
+  }, [setIsGuideCueVisible, stageIndex, isIntersecting]);
 
   const setGuideCueVisited = () => {
     setIsGuideCueVisible(false);

packages/compass-preferences-model/src/preferences.ts

@@ -17,7 +17,6 @@ export type FeatureFlags = {
   showDevFeatureFlags?: boolean;
   lgDarkmode?: boolean;
   debugUseCsfleSchemaMap?: boolean;
-  showFocusMode?: boolean;
   useNewExportBackend?: boolean;
 };
 
@@ -255,22 +254,6 @@ const featureFlagsProps: Required<{
     },
   },
 
-  /**
-   * Feature flag for the focus mode in aggregation pipeline builder.
-   */
-  showFocusMode: {
-    type: 'boolean',
-    required: false,
-    default: true,
-    ui: true,
-    cli: true,
-    global: true,
-    description: {
-      short: 'Focus Mode in Stage Editor',
-      long: 'Use focus mode to compose aggregation pipeline stage.',
-    },
-  },
-
   /**
    * Feature flag for enabling the use of the new backend api for
    * exporting documents. Epic: COMPASS-5576