COMPASS-849: Backport COMPASS 832 - Return to avoid running the success case on error of insert document (#821) (#826)

pzrq · web-flow · commit 886466dcfb7c · 2017-03-06T13:54:20.000+11:00
#retry "Compass Functional Tests for QueryBar #spectron" https://travis-ci.com/10gen/compass/jobs/67359963 "renders the home screen" https://travis-ci.com/10gen/compass/jobs/67360320 "renders the home screen" https://travis-ci.com/10gen/compass/jobs/67361030 "hangs running renderer tests" https://travis-ci.com/10gen/compass/jobs/67360781 "Error: ENOENT: no such file or directory, open '/home/travis/build/10gen/compass/node_modules/electron-prebuilt/path.txt'" https://travis-ci.com/10gen/compass/jobs/67361031 "Schema - renders field types" https://travis-ci.com/10gen/compass/jobs/67361464
diff --git a/src/internal-packages/crud/lib/store/insert-document-store.js b/src/internal-packages/crud/lib/store/insert-document-store.js
@@ -27,7 +27,7 @@ const InsertDocumentStore = Reflux.createStore({
   insertDocument: function(doc) {
     app.dataService.insertOne(NamespaceStore.ns, doc, {}, (error) => {
       if (error) {
-        this.trigger(false, error);
+        return this.trigger(false, error);
       }
       // check if the newly inserted document matches the current filter, by
       // running the same filter but targeted only to the doc's _id.

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ const InsertDocumentStore = Reflux.createStore({`
`27`	`27`	`insertDocument: function(doc) {`
`28`	`28`	`app.dataService.insertOne(NamespaceStore.ns, doc, {}, (error) => {`
`29`	`29`	`if (error) {`
`30`		`- this.trigger(false, error);`
	`30`	`+ return this.trigger(false, error);`
`31`	`31`	`}`
`32`	`32`	`// check if the newly inserted document matches the current filter, by`
`33`	`33`	`// running the same filter but targeted only to the doc's _id.`