chore: one should be enough? (#3079)

* one should be enough?

* add debugging

* timeout closing compass before the afterAll can timeout

Author: lerouxb

.evergreen/functions.yml

@@ -81,17 +81,9 @@ post:
     params:
       local_files_include_filter:
         - src/packages/compass-e2e-tests/.log/**/*
-  - <<: *save-diagnostic-file
-    params:
-      local_files_include_filter:
         - src/packages/compass-e2e-tests/.nyc_output/coverage.json
-  - <<: *save-diagnostic-file
-    params:
-      local_files_include_filter:
+        - src/packages/compass-e2e-tests/.log/report.json
         - ~/.mongodb/runner/*.log
-  - command: attach.results
-    params:
-      file_location: src/packages/compass-e2e-tests/.log/report.json
 
 functions:
   clone:

packages/compass-e2e-tests/helpers/commands/shell-eval.ts

@@ -57,6 +57,7 @@ export async function shellEval(
     } catch (err) {
       // just leave it unparsed for now if there's a parse error because
       // that's really helpful when debugging
+      console.error('Could not parse result:', result);
     }
   }
 

packages/compass-e2e-tests/helpers/compass.ts

@@ -628,18 +628,32 @@ export async function afterTests(
     await compass.capturePage(filename);
   }
 
-  try {
-    await compass.stop(test);
-  } catch (err) {
-    debug('An error occurred while stopping compass:');
-    debug(err);
+  let timeoutId;
+  const timeoutPromise = new Promise<void>((resolve) => {
+    timeoutId = setTimeout(() => {
+      console.error('It took too long to close compass');
+      resolve();
+    }, 30000);
+  });
+
+  const closePromise = (async function close(): Promise<void> {
     try {
-      // make sure the process can exit
-      await compass.browser.deleteSession();
-    } catch (_) {
-      debug('browser already closed');
+      await compass.stop(test);
+    } catch (err) {
+      debug('An error occurred while stopping compass:');
+      debug(err);
+      try {
+        // make sure the process can exit
+        await compass.browser.deleteSession();
+      } catch (_) {
+        debug('browser already closed');
+      }
     }
-  }
+    clearTimeout(timeoutId);
+    return;
+  })();
+
+  return Promise.race([timeoutPromise, closePromise]);
 }
 
 function pathName(text: string) {