chore(eslint): re-enable no-floating-promises COMPASS-9459 (#7020)

chore(eslint): re-enable no-floating-promises

Author: gribnoysup

configs/eslint-config-compass/index.js

@@ -35,7 +35,6 @@ const extraTsRules = {
   '@typescript-eslint/unbound-method': 'warn',
   '@typescript-eslint/no-duplicate-type-constituents': 'warn',
   '@typescript-eslint/no-unsafe-declaration-merging': 'warn',
-  '@typescript-eslint/no-floating-promises': 'warn',
   '@typescript-eslint/no-unsafe-enum-comparison': 'warn',
   '@typescript-eslint/no-misused-promises': 'warn',
 };

packages/compass/src/main/auto-update-manager.spec.ts

@@ -24,7 +24,7 @@ function setStateAndWaitForUpdate(
       if (newState === expected) {
         resolved = true;
         CompassAutoUpdateManager.off('new-state', resolveWhenState);
-        Promise.resolve(
+        void Promise.resolve(
           CompassAutoUpdateManager['currentStateTransition']
         ).finally(() => {
           CompassAutoUpdateManager['currentActionAbortController'].abort();

packages/compass/src/main/index.ts

@@ -116,13 +116,13 @@ async function main(): Promise<void> {
       process.stderr.write('Exiting due to uncaughtException:\n');
       // eslint-disable-next-line no-console
       console.error(err);
-      CompassApplication.runExitHandlers().finally(() => app.exit(1));
+      void CompassApplication.runExitHandlers().finally(() => app.exit(1));
     });
     process.on('unhandledRejection', (err) => {
       process.stderr.write('Exiting due to unhandledRejection:\n');
       // eslint-disable-next-line no-console
       console.error(err);
-      CompassApplication.runExitHandlers().finally(() => app.exit(1));
+      void CompassApplication.runExitHandlers().finally(() => app.exit(1));
     });
   }
 

packages/data-service/src/instance-detail-helper.spec.ts

@@ -277,26 +277,24 @@ describe('instance-detail-helper', function () {
       });
 
       context('isAtlas and isLocalAtlas', function () {
-        it(`should be identified as atlas with hostname correct hostnames`, function () {
-          ['myserver.mongodb.net', 'myserver.mongodb-dev.net'].map(
-            async (hostname) => {
-              const { client, connectionString } = createMongoClientMock({
-                hosts: [{ host: hostname, port: 9999 }],
-                commands: {
-                  buildInfo: {},
-                  getCmdLineOpts: fixtures.CMD_LINE_OPTS,
-                },
-              });
+        for (const hostname of [
+          'myserver.mongodb.net',
+          'myserver.mongodb-dev.net',
+        ]) {
+          it(`should be identified as atlas when hostname = ${hostname}`, async function () {
+            const { client, connectionString } = createMongoClientMock({
+              hosts: [{ host: hostname, port: 9999 }],
+              commands: {
+                buildInfo: {},
+                getCmdLineOpts: fixtures.CMD_LINE_OPTS,
+              },
+            });
 
-              const instanceDetails = await getInstance(
-                client,
-                connectionString
-              );
+            const instanceDetails = await getInstance(client, connectionString);
 
-              expect(instanceDetails).to.have.property('isAtlas', true);
-            }
-          );
-        });
+            expect(instanceDetails).to.have.property('isAtlas', true);
+          });
+        }
 
         it(`should be identified as atlas when atlasVersion command is present`, async function () {
           const { client, connectionString } = createMongoClientMock({