Skip to content

Commit 8e43390

Browse files
authored
chore(monorepo): make sure we don't leave root level electron in package-lock (#5236)
* chore(monorepo): make sure we don't leave root level electron in package-lock * chore: update comment
1 parent da7eb23 commit 8e43390

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

scripts/update-electron.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,13 @@ async function cleanAndBootstrap(electronVersion) {
1111
await runInDir('rm -Rf node_modules');
1212
const packageJsonBkp = fs.readFileSync('./package.json');
1313
await runInDir('npm i');
14-
await runInDir(`npm i electron@${electronVersion}`); // make sure electron is hoisted on the root
14+
// Make sure electron is hoisted on the root
15+
await runInDir(`npm i electron@${electronVersion}`);
1516
await runInDir('npm run bootstrap');
1617
fs.writeFileSync('./package.json', packageJsonBkp);
18+
// Run install again to make sure root level electron is removed from
19+
// package-lock
20+
await runInDir('npm i');
1721
} catch (error) {
1822
console.error(`Error running command: ${error}`);
1923
}

0 commit comments

Comments
 (0)