fix(compass-import-export): remove re-count when not available COMPASS-5179, COMPASS-6649 (#4237)

Author: Anemy

packages/compass-import-export/src/modules/cursor-exporter.ts

@@ -17,7 +17,6 @@ export class CursorExporter extends EventEmitter {
   private _output: stream.Writable;
   private _formatter;
   private _columns: Array<string> | boolean;
-  private _totalNumberOfDocuments: number;
   private _exportedDocuments = 0;
   private _cursorStream: stream.Readable;
   constructor(opts: CursorExporterOpts) {
@@ -28,7 +27,6 @@ export class CursorExporter extends EventEmitter {
       opts.type === 'csv' ? createCSVFormatter : createJSONFormatter;
     this._output = opts.output;
     this._columns = opts.columns ? opts.columns : true;
-    this._totalNumberOfDocuments = opts.totalNumberOfDocuments || 0;
   }
 
   async start(): Promise<void> {

packages/compass-import-export/src/modules/export.spec.js

@@ -53,10 +53,7 @@ describe('export [module]', function () {
 
         store.dispatch(dataServiceConnected(null, dataService));
         store.dispatch(globalAppRegistryActivated(globalAppRegistry));
-
-        // Manually awaiting a thunk to make sure that store is ready for the
-        // tests
-        await store.dispatch(
+        store.dispatch(
           actions.openExport({
             namespace: TEST_COLLECTION_NAME,
             query: {},
@@ -70,7 +67,14 @@ describe('export [module]', function () {
         fileType,
         tempFile
       ) {
-        store.dispatch(actions.openExport('foo.bar', { filter: {} }, 0, null));
+        store.dispatch(
+          actions.openExport({
+            namespace: TEST_COLLECTION_NAME,
+            query: { filter: {} },
+            count: 0,
+            aggregation: undefined,
+          })
+        );
         store.dispatch(actions.updateSelectedFields(selectedFields));
         store.dispatch(actions.selectExportFileName(tempFile));
         store.dispatch(actions.selectExportFileType(fileType));

packages/compass-import-export/src/modules/export.ts

@@ -398,28 +398,15 @@ export const openExport =
   }: {
     namespace: string;
     query: ExportQueryType;
-    // Optional pre supplied count to shortcut and
-    // avoid a possibly expensive re-count.
+    // Optional pre supplied count, this helps us show progress.
     count?: number;
     aggregation?: ExportAggregationType;
-  }): ThunkAction<Promise<void>, RootExportState, void, AnyAction> =>
-  async (dispatch, getState) => {
+  }) =>
+  (dispatch: Dispatch) => {
     const isAggregation = !!aggregation;
     track('Export Opened', { type: isAggregation ? 'aggregation' : 'query' });
-    const {
-      dataService: { dataService },
-    } = getState();
 
-    let count = null;
-    try {
-      count =
-        maybeCount ??
-        (!isAggregation
-          ? await fetchDocumentCount(dataService!, namespace, query)
-          : null);
-    } catch (e: unknown) {
-      dispatch(onError(e as Error));
-    }
+    const count = maybeCount ?? null;
     dispatch(nsChanged(namespace));
     dispatch(onModalOpen({ namespace, query, count, aggregation }));
   };
@@ -495,7 +482,6 @@ export const startExport =
         type: exportData.fileType,
         columns: columns,
         output: dest,
-        totalNumberOfDocuments: numDocsToExport,
       });
 
       const throttledProgress = throttle(